New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash from possible division by zero #1211

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@ashfurrow
Member

ashfurrow commented Oct 31, 2018

I was looking at Eigen's Sentry logs and came across this new crash from 4.3.2:

Application threw exception CALayerInvalidGeometry: CALayer position contains NaN: [nan 110]

(It's only happened to one user so far.)

I took a look at the code and it looks like in some edge cases, we might be dividing by zero to calculate the aspect ratio. I put in a check for isnan first, hopefully this will fix it.

@DangerCI

This comment has been minimized.

DangerCI commented Oct 31, 2018

Fails
🚫

This PR includes changes to the Emission Pod's native code but does not have a package.json change for the update to the "native-code-version". If this is fine, add #native_no_changes to your PR message.

Generated by 🚫 dangerJS

@ashfurrow ashfurrow force-pushed the crash-fix branch from cd07362 to 8e63446 Oct 31, 2018

@ashfurrow

This comment has been minimized.

Member

ashfurrow commented Oct 31, 2018

Danger passed but the error comment is still there. Hmm.

@orta

This comment has been minimized.

Member

orta commented Oct 31, 2018

We might be using an old build of danger locally - I know there was an API change for deleting posts

@ashfurrow ashfurrow merged commit bc1edef into master Oct 31, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ashfurrow ashfurrow deleted the crash-fix branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment