Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eslint typescript rules #167

Merged
merged 1 commit into from Aug 31, 2022
Merged

feat: eslint typescript rules #167

merged 1 commit into from Aug 31, 2022

Conversation

pvinis
Copy link
Contributor

@pvinis pvinis commented Aug 31, 2022

Description

This PR resolves []

this is added mostly for the strict boolean rule

PR Checklist

  • I tested my changes on iOS and Android.
  • I added screenshots or videos to illustrate my changes.
  • I added Tests and Stories for my changes.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

@pvinis pvinis requested review from rajsam003 and a team August 31, 2022 12:32
@pvinis
Copy link
Contributor Author

pvinis commented Aug 31, 2022

@rajsam003 id say lets merge this first, and then rebase #166 on top, and then you can refactor the ones you like, while ignoring the rest, or finding better ways for them.

Copy link
Contributor

@rajsam003 rajsam003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@rajsam003 rajsam003 merged commit 3367d66 into main Aug 31, 2022
4 checks passed
@rajsam003 rajsam003 deleted the pvinis/eslint-stuff branch August 31, 2022 13:01
@MounirDhahri
Copy link
Member

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants