New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against ElasticSearch 1.7.6 and 1.5.2. #25

Merged
merged 2 commits into from Feb 13, 2017

Conversation

Projects
None yet
2 participants
@dblock
Member

dblock commented Feb 10, 2017

@dblock dblock changed the title from WIP: Test against ElasticSearch 1.7.6 and 1.5.2. to Test against ElasticSearch 1.7.6 and 1.5.2. Feb 10, 2017

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Feb 10, 2017

Member

Ready to merge @cavvia.

Member

dblock commented Feb 10, 2017

Ready to merge @cavvia.

- "sudo /etc/init.d/elasticsearch start"
- "sleep 5"
- sudo /etc/init.d/elasticsearch start
- until curl --silent -XGET --fail http://localhost:9200; do printf '.'; sleep 1; done

This comment has been minimized.

@cavvia

cavvia Feb 13, 2017

Collaborator

good use of until!

@cavvia

cavvia Feb 13, 2017

Collaborator

good use of until!

- ELASTICSEARCH=https://download.elastic.co/elasticsearch/release/org/elasticsearch/distribution/deb/elasticsearch/2.4.4/elasticsearch-2.4.4.deb
- ELASTICSEARCH=https://download.elasticsearch.org/elasticsearch/release/org/elasticsearch/distribution/deb/elasticsearch/2.1.1/elasticsearch-2.1.1.deb
- ELASTICSEARCH=https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.7.6.deb
- ELASTICSEARCH=https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.5.2.deb

This comment has been minimized.

@cavvia

cavvia Feb 13, 2017

Collaborator

I wasn't aware of this Travis feature (doc here) - just to clarify, this will trigger a build per ENV var when a var has been defined multiple times. 👍

@cavvia

cavvia Feb 13, 2017

Collaborator

I wasn't aware of this Travis feature (doc here) - just to clarify, this will trigger a build per ENV var when a var has been defined multiple times. 👍

This comment has been minimized.

@dblock

dblock Feb 13, 2017

Member

Indeed, it will, one for each.

@dblock

dblock Feb 13, 2017

Member

Indeed, it will, one for each.

@cavvia

This comment has been minimized.

Show comment
Hide comment
@cavvia

cavvia Feb 13, 2017

Collaborator

I haven't used this multi-build technique before, looks great.

Collaborator

cavvia commented Feb 13, 2017

I haven't used this multi-build technique before, looks great.

@cavvia cavvia merged commit 4a86479 into artsy:master Feb 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.441%
Details

@dblock dblock deleted the dblock:multiple-versions-of-es branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment