Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with updated installation instructions #164

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@dblandin
Copy link
Member

commented Jun 12, 2019

Updated the README with updated installation instructions, including the new preferred homebrew installation method for OSX users.

@dblandin dblandin requested review from izakp and eessex Jun 12, 2019

2) [Configure your AWS credentials](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html#configuring-credentials).

3) Run `hokusai configure --kubectl-version <kubectl version> --s3-bucket <bucket name> --s3-key <file key>`. You'll need to provide the kubectl version matching your Kubernetes deployments, as well as the S3 bucket name and key of your org's kubectl config file. System administrators: see [Administering Hokusai](./docs/Administering_Hokusai.md) for instructions on preparing AWS, Kubernetes, and publishing a kubectl config file. Artsy devs: see [these artsy/README docs](https://github.com/artsy/README/blob/master/playbooks/hokusai.md) for the current way to install and configure hokusai.
1. [Configure your AWS credentials](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html#configuring-credentials).

This comment has been minimized.

Copy link
@eessex

eessex Jun 12, 2019

Member

These are both under #1

This comment has been minimized.

Copy link
@dblandin

dblandin Jun 12, 2019

Author Member

When writing ordered lists in Markdown, the numbers actually aren't rendered directly. Markdown automatically handles the rendering for you. The numbers could even be out of order, or all 3. and Markdown will still render 1, 2, 3.

This is nice because when updating a list, you don't have to touch items unrelated to your change.

source: https://daringfireball.net/projects/markdown/syntax#list

screenshot 1560359596

@eessex

eessex approved these changes Jun 12, 2019

Copy link
Member

left a comment

Just one minor typo, otherwise looks good- thank you!

@eessex eessex merged commit a0124f7 into artsy:master Jun 12, 2019

3 checks passed

ci/circleci: test_integration Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_macos Your tests passed on CircleCI!
Details

@dblandin dblandin deleted the dblandin:update-readme branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.