New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stitches KAWS #1327

Merged
merged 9 commits into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@l2succes
Copy link
Contributor

l2succes commented Oct 11, 2018

Depends on: artsy/kaws#4

Adds support for the following query

{
  marketingCollection(slug: "kaws-companions") {
    id
    title
    query {
      artist_ids
      artist_id
      gene_id
    }
    artworks {
      __id
      hits {
    	id
        title
      }
    }
  }
}

screen shot 2018-10-11 at 3 43 40 pm

@l2succes l2succes requested review from orta , eessex and xtina-starr Oct 11, 2018

@@ -48,6 +51,20 @@ export const incrementalMergeSchemas = (testConfig?: any) => {
}
}

if (ENABLE_KAWS_STITCHING) {

This comment has been minimized.

@orta

orta Oct 11, 2018

Member

TBH, you can probably skip this env var and always stitch 👍

This comment has been minimized.

@l2succes

l2succes Oct 11, 2018

Contributor

True, I'm just gonna leave it for now as I don't have KAWS setup on production yet

This comment has been minimized.

@orta

orta Oct 11, 2018

Member

Cool - your errors are beast the .env.testing doesn't have the URLs set

This comment has been minimized.

@l2succes

l2succes Oct 11, 2018

Contributor

Yeah, I noticed, just set the variable via hokusai but I may have to set a default 🤔

This comment has been minimized.

@l2succes

l2succes Oct 11, 2018

Contributor

Nevermind, I see what you're saying... just updated .env.test

l2succes added some commits Oct 11, 2018

@l2succes l2succes merged commit 28c51ff into master Oct 11, 2018

1 check passed

ci/circleci: test Your tests passed on CircleCI!
Details

@l2succes l2succes deleted the kaws-stitching branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment