@alloy=>Fixed has_metadata check #302

Merged
merged 1 commit into from Jun 3, 2016

Conversation

Projects
None yet
3 participants
@sarahscott
Contributor

sarahscott commented Jun 3, 2016

{
  "data": {
    "artist": {
      "has_metadata": true,
      "bio": "British, 1928-2011, Sheffield, United Kingdom",
      "blurb": null
    }
  }
}

Fixes bio problem in #301

@sarahscott sarahscott changed the title from @alloy=>Fixed has_metadata check to [WIP]@alloy=>Fixed has_metadata check Jun 3, 2016

@sarahscott sarahscott changed the title from [WIP]@alloy=>Fixed has_metadata check to @alloy=>Fixed has_metadata check Jun 3, 2016

@alloy

This comment has been minimized.

Show comment
Hide comment
@alloy

alloy Jun 3, 2016

Contributor

I feel like we shouldn’t have to check all those underlying fields, but for now this seems good, so I’m merging it.

@dzucconi Is there a way that we can clean this up by just checking the bio field that metaphysics populates?

Contributor

alloy commented Jun 3, 2016

I feel like we shouldn’t have to check all those underlying fields, but for now this seems good, so I’m merging it.

@dzucconi Is there a way that we can clean this up by just checking the bio field that metaphysics populates?

@alloy alloy merged commit c6f592c into master Jun 3, 2016

1 check passed

semaphoreci The build passed on Semaphore.
Details

@alloy alloy deleted the has-metadata-fix branch Jun 3, 2016

@dzucconi

This comment has been minimized.

Show comment
Hide comment
@dzucconi

dzucconi Jun 3, 2016

Contributor

If you want to extract some functions; sure you can do that, a la https://github.com/artsy/metaphysics/blob/master/schema/artwork/utilities.js —There's no (real) way to use a computed resolve elsewhere, without first extracting it though.

Contributor

dzucconi commented Jun 3, 2016

If you want to extract some functions; sure you can do that, a la https://github.com/artsy/metaphysics/blob/master/schema/artwork/utilities.js —There's no (real) way to use a computed resolve elsewhere, without first extracting it though.

@alloy

This comment has been minimized.

Show comment
Hide comment
@alloy

alloy Jun 6, 2016

Contributor

@dzucconi Gotcha, makes sense.

Contributor

alloy commented Jun 6, 2016

@dzucconi Gotcha, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment