New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automates reminders to on-call engineers that they are running standup #87

Merged
merged 5 commits into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@ashfurrow
Copy link
Member

ashfurrow commented Dec 14, 2018

This PR automates a task I've been doing manually for most of the year, which is reminding the on-call engineers that it's their responsibility to run standup.

Still left to do:

  • Put GSuite credentials and calendar ID into Peril's env var settings
  • Look up Slack users based on email addresses
  • Post message to Slack
  • Update Peril config to schedule task
  • Unit tests
@@ -10,6 +10,7 @@
},
"dependencies": {
"@types/graphql": "^14.0.3",
"googleapis": "^36.0.0",

This comment has been minimized.

@orta

orta Dec 16, 2018

Member

this would need to be added to peril's dependencies - which I think is reasonable

ashfurrow added some commits Jan 5, 2019

@ashfurrow

This comment has been minimized.

Copy link
Member Author

ashfurrow commented Jan 5, 2019

@sweir27 I wanted to flag this with you: I took a look at the on call calendar to try and synthesize some conventions, but once we merge this PR, we'll have code relying on those conventions, so we should double-check first. What the code assumes is:

  • Calendar events from the On-Call calendar have the engineers named in those events listed as attendees. (Sarah is sometimes also an attendee, but the code accommodates that by filtering her out if there are multiple attendees.)
  • The on-call staff who run the standup are the engineer starting their shift and the engineer continuing their shift.

I think that's it. I'm going to write some unit tests later, and I'm hoping to run this through its paces on Monday morning.

@ashfurrow ashfurrow changed the title WIP: Automates reminders to on-call engineers that they are running standup Automates reminders to on-call engineers that they are running standup Jan 6, 2019

@ashfurrow ashfurrow assigned ashfurrow and orta and unassigned ashfurrow Jan 6, 2019

@orta

This comment has been minimized.

Copy link
Member

orta commented Jan 7, 2019

Yep, this looks good to me 👍

Really nice to see such high level Peril usage!

@orta orta merged commit 36ccb57 into master Jan 7, 2019

3 checks passed

Peril :warning: Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@orta

This comment has been minimized.

Copy link
Member

orta commented Jan 7, 2019

( You should write a blog post )

@ashfurrow ashfurrow referenced this pull request Jan 7, 2019

Merged

Fix the slackup note #94

@ashfurrow ashfurrow deleted the automate-weekly-standup-reminders branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment