Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Configuration file before using it #516

Closed
vanniktech opened this issue Oct 22, 2017 · 1 comment
Closed

Validate Configuration file before using it #516

vanniktech opened this issue Oct 22, 2017 · 1 comment
Labels
api feature
Projects
Roadmap
Milestone
1.2.0

Comments

@vanniktech
Copy link
Contributor

This would have caught the typo in LateInitUsage really early. In addition upgrading from RC's to the final version where we'll rename some of the rules would automatically notify the users to adjust their configuration files.

As a side note, comments should be ignored while validating.
@vanniktech vanniktech mentioned this issue Feb 21, 2018
Closed
@Mauin Mauin changed the title Fail early when configuration file has incorrect entries Validate Configuration file before using it Oct 7, 2018
@arturbosch arturbosch added this to the 1.0.0 milestone Nov 14, 2018
@Mauin Mauin mentioned this issue Nov 27, 2018
Closed
@arturbosch arturbosch mentioned this issue Dec 7, 2018
Closed
@arturbosch arturbosch modified the milestones: 1.0.0, 1.1.0 Feb 9, 2019
This was referenced Feb 13, 2019
Open
Closed
@schalkms
Copy link
Member

One could take a look at the io.gitlab.arturbosch.detekt.cli.DetektYmlConfigTest, where we validate the yaml config in an integration test.
I think some of the logic there can be taken to implement this feature.

@schalkms schalkms mentioned this issue Jul 27, 2019
Closed
@arturbosch arturbosch added this to Backlog in Roadmap Sep 6, 2019
@arturbosch arturbosch modified the milestones: 1.1.0, 1.2.0 Sep 17, 2019
@arturbosch arturbosch removed this from Backlog in Roadmap Sep 17, 2019
@arturbosch arturbosch mentioned this issue Sep 26, 2019
Closed
@arturbosch arturbosch added this to Backlog in Roadmap Oct 6, 2019
arturbosch added a commit that referenced this issue Oct 8, 2019
@arturbosch
Validate yaml configurations by comparing their structure - #516
05e6df8
arturbosch added a commit that referenced this issue Oct 30, 2019
@arturbosch
Validate yaml configurations by comparing their structure - #516
5c5b550
arturbosch added a commit that referenced this issue Nov 3, 2019
@arturbosch
Validate yaml configurations by comparing their structure - #516 (#1998)
6c37955 
* Validate yaml configurations by comparing their structure - #516

* Towards supporting composite config validation

* Generalize config validation interface

* Fix formatting

* Delete non existing rule configurations

* Support excluding config properties from validation

* Use settings#info to print invalid properties

* Exclude common rule properties by default from validation

* Regenerate default configuration

* Rename validation message functions
@arturbosch arturbosch moved this from Backlog to Done in Roadmap Nov 5, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this issue Dec 9, 2019
@arturbosch @smyachenkov
Validate yaml configurations by comparing their structure - detekt#516 (
8ca083a 
detekt#1998)

* Validate yaml configurations by comparing their structure - detekt#516

* Towards supporting composite config validation

* Generalize config validation interface

* Fix formatting

* Delete non existing rule configurations

* Support excluding config properties from validation

* Use settings#info to print invalid properties

* Exclude common rule properties by default from validation

* Regenerate default configuration

* Rename validation message functions
smyachenkov pushed a commit to smyachenkov/detekt that referenced this issue Dec 9, 2019
@arturbosch
Validate yaml configurations by comparing their structure - detekt#516 (
8dd4f33 
detekt#1998)

* Validate yaml configurations by comparing their structure - detekt#516

* Towards supporting composite config validation

* Generalize config validation interface

* Fix formatting

* Delete non existing rule configurations

* Support excluding config properties from validation

* Use settings#info to print invalid properties

* Exclude common rule properties by default from validation

* Regenerate default configuration

* Rename validation message functions
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api feature
Projects
Roadmap
  
Done
Milestone
1.2.0
Development

No branches or pull requests
4 participants
@vanniktech @Mauin @arturbosch @schalkms