Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnusedPrivateMember: Incorrectly reports unused params in open/abstract functions #972

Closed
marianosimone opened this issue Jun 27, 2018 · 3 comments
Milestone

Comments

@marianosimone
Copy link
Contributor

The rule is over-reporting

For the following example:

open class Foo {
    abstract fun foo(bar: Bar): Unit
}

class Foo2 : Foo {
    override fun foo(bar: Bar) {
        bar.bar()
    }
}

Expected Behavior

Nothing should be reported

Current Behavior

reports bar in Foo#foo as unused

This seems related to (my) changes in #968, and somehow got released to RC7-2 (instead of to the recently release RC7-3)

@marianosimone
Copy link
Contributor Author

I'm working on a fix for this right now

@arturbosch
Copy link
Member

Thanks for the fast fix!

@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants