New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of classpaths in Gradle plugin #1609
Conversation
2005719
to
f6d61bc
Compare
The code looks nice and clean to me. Is there a use case for users of the detekt plugin to set the |
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt
Show resolved
Hide resolved
Usually, no, I expect users would just use the defaults and possibly change the version of the CLI dependency using |
43288dc
to
b7f5564
Compare
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
=========================================
Coverage 79.62% 79.62%
Complexity 1963 1963
=========================================
Files 335 335
Lines 5527 5527
Branches 1014 1014
=========================================
Hits 4401 4401
Misses 593 593
Partials 533 533 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
========================================
Coverage 76.2% 76.2%
Complexity 1841 1841
========================================
Files 318 318
Lines 5456 5456
Branches 1007 1007
========================================
Hits 4158 4158
Misses 754 754
Partials 544 544 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks finish to me, this PR just needs CI restart? Correct me if I'm wrong.
Now has merge conflicts, I can rebase so will rerun CI. |
Yes please, sorry for the trouble. |
This change achieves a few things:
detektPlugins
configuration which isn't currently possible (refer Allow custom report format to be defined by Gradle Plugin #1596 for details)This change should not impact anyone's existing build configuration.
cc: @marschwar