Added factory function check to MemberNameEqualsClassName #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory functions that create an instance of the class can now have the same name as the class.
schalkms
commented
Dec 30, 2017
|
|
||
| private fun isFactoryMethod(function: KtNamedFunction, klass: KtClass): Boolean { | ||
| val typeReference = function.typeReference | ||
| return typeReference == null && function.bodyExpression !is KtBlockExpression |
There was a problem hiding this comment.
This ignores functions which return a single expression since detekt cannot infer the type (at the moment).
Consider the following code for example
open class A {
companion object {
// return type = A
fun a(condition: Boolean) = if (condition) B() else C()
}
}
class B: A()
class C: A()
arturbosch
approved these changes
Jan 1, 2018
arturbosch
reviewed
Jan 1, 2018
| } | ||
| private fun getMisnamedCompanionObjectMembers(klass: KtClass): List<KtNamedDeclaration> { | ||
| val list = mutableListOf<KtNamedDeclaration>() | ||
| klass.companionObjects.forEach { list.addAll(getMisnamedMembers(it, klass.name)) } |
There was a problem hiding this comment.
This can be just a flatMap-Funktion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the feature mentioned in #652