Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: condition for communicate_threaded #86

Closed
ObiWahn opened this issue Mar 20, 2023 · 1 comment
Closed

question: condition for communicate_threaded #86

ObiWahn opened this issue Mar 20, 2023 · 1 comment

Comments

@ObiWahn
Copy link
Contributor

ObiWahn commented Mar 20, 2023

https://github.com/arun11299/cpp-subprocess/blob/master/subprocess.hpp#L1875

I wonder if this condition should be negated.
@ObiWahn ObiWahn changed the title question: condtion for communicate_threaded question: condition for communicate_threaded Mar 20, 2023
@ObiWahn
Copy link
Contributor Author

ObiWahn commented Mar 20, 2023

I started rewriting the code and then understood that you are counting the the nullptrs :) Sorry for the noise!

@ObiWahn ObiWahn closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ObiWahn