New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticate / authorize behavior is now the same #120

Open
ThisIsMissEm opened this Issue Nov 11, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ThisIsMissEm

ThisIsMissEm commented Nov 11, 2017

Previously if you used "authenticate", then if the twitter user had already authorized your app, you'd be redirect straight back to the application without user interaction. In a recent change they made "authenticate" behave the same as "authorize".

This results in the following changes:

  • README / documentation stating the behavior difference is incorrect
  • There is no difference, so there's no reason to switch between authenticate and authorize based on configuration. This would be a code change, deprecating the "authorize" feature.

I'm wondering how you'd like a pull request to make the appropriate changes / if you want those changes. I was a little confused why I was always getting the interstitial screen, no matter what my configuration was, and found this twitter change to be the answer. Rather than letting everyone slowly figure this out, I feel like it'd be better for me to contribute a change back to align things.

@raysrashmi

This comment has been minimized.

Collaborator

raysrashmi commented Nov 23, 2017

You can make changes in your branch and then make PR

@ThisIsMissEm

This comment has been minimized.

ThisIsMissEm commented Dec 25, 2017

@raysrashmi okay, so, you're onboard with the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment