Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use HTTPS for Twitter URL #54

Merged
merged 3 commits into from Apr 3, 2013

Conversation

Projects
None yet
4 participants
Contributor

sferik commented Apr 3, 2013

Avoid unnecessary HTTP 301s.

This pull request also includes the bugfix commit from @sbellity in #52, which is on the same line and would otherwise cause a conflict in the diff.

arunagw added a commit that referenced this pull request Apr 3, 2013

Merge pull request #54 from sferik/https
Use HTTPS for Twitter URL

@arunagw arunagw merged commit 3ced123 into arunagw:master Apr 3, 2013

Owner

arunagw commented Apr 3, 2013

thanks 👍

@potomak potomak commented on the diff May 17, 2013

lib/omniauth/strategies/twitter.rb
@@ -20,7 +20,7 @@ class Twitter < OmniAuth::Strategies::OAuth
:description => raw_info['description'],
:urls => {
'Website' => raw_info['url'],
- 'Twitter' => 'http://twitter.com/' + raw_info['screen_name'],
+ 'Twitter' => "https://twitter.com/#{raw_info['screen_name']}",
@potomak

potomak May 17, 2013

This seems to solve #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment