Permalink
Switch branches/tags
Commits on Nov 21, 2017
  1. Merge pull request #31188 from tgxworld/update_rack_test

    y-yagi committed Nov 21, 2017
    FIX: `rack-test` 0.7.1 probably got yanked.
  2. Update `rack-test` to 0.8.

    tgxworld committed Nov 21, 2017
  3. Remove unused `em-hiredis`

    y-yagi committed Nov 21, 2017
    `em-hiredis` is unused since 48766e3
Commits on Nov 20, 2017
  1. Provide attachment writers

    georgeclaghorn committed Nov 20, 2017
    Permit creating a record and attaching files in a single step.
    
        # Before:
        User.create!(user_params.except(:avatar)).tap do |user|
          user.avatar.attach(user_params[:avatar])
        end
    
        # After:
        User.create!(user_params)
    
    [Yoshiyuki Hirano & George Claghorn]
  2. MemCacheStore: Support expiring counters

    aeroastro committed with jeremy Nov 18, 2017
    Support `expires_in` in `ActiveSupport::Cache::MemCacheStore#increment`
    and `#decrement`.
    
    Closes #30716.
  3. Fix direct uploads to local service

    georgeclaghorn committed Nov 20, 2017
    Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens.
    
    Closes #30290.
    
    [Shinichi Maeshima & George Claghorn]
  4. Merge pull request #31185 from vipulnsward/threading-guide

    vipulnsward committed Nov 20, 2017
    Pass over Execution guide[ci skip]
Commits on Nov 19, 2017
  1. Merge pull request #31170 from PHedkvist/system_testing_guides

    matthewd committed Nov 19, 2017
    [ci skip] Added example for using headless_chrome with SystemTest
  2. Permit attaching files to new records

    georgeclaghorn committed Nov 19, 2017
    Closes #31164.
  3. Prevent extra `spawn` to make `klass.all` faster (#29009)

    kamipo committed Nov 19, 2017
    These extra `spawn` are called via `klass.all` and `klass.all` is called
    everywhere in the internal. Avoiding the extra `spawn` makes` klass.all`
    30% faster for STI classes.
    
    https://gist.github.com/kamipo/684d03817a8115848cec8e8b079560b7
    
    ```
    Warming up --------------------------------------
           fast relation     4.410k i/100ms
           slow relation     3.334k i/100ms
    Calculating -------------------------------------
           fast relation     47.373k (± 5.2%) i/s -    238.140k in   5.041836s
           slow relation     35.757k (±15.9%) i/s -    176.702k in   5.104625s
    
    Comparison:
           fast relation:    47373.2 i/s
           slow relation:    35756.7 i/s - 1.32x  slower
    ```
  4. Generate `keys` instead of `keys_to_names`

    kamipo committed Nov 19, 2017
    `keys_to_names` is used only for `keys_to_names.keys`.
Commits on Nov 18, 2017
  1. Deprecate an `after_bundle` callback in Rails plugin templates

    y-yagi committed Jun 12, 2017
    Since fbd1e98, Rails plugin does not
    run `bundle install` when generating.
    Therefore, `after_bundle` callback is not actually executed after `bundle`.
    
    Since there is a difference between the name and the actual behavior,
    I think that should be remove.
Commits on Nov 17, 2017
  1. Merge pull request #31035 from BrentWheeldon/bmw-db-load-deadlock

    matthewd committed Nov 17, 2017
    Prevent deadlocks with load interlock and DB lock.
  2. Merge pull request #28742 from quixoten/stack_conn_pool

    matthewd committed Nov 17, 2017
    Switch to LIFO for the connection pool
  3. Merge pull request #28869 from eugeneius/query_cache_all_pools

    matthewd committed Nov 17, 2017
    Enable query cache on all connection pools
  4. Merge pull request #30100 from kirs/doc-reloader

    matthewd committed Nov 17, 2017
    Document public hooks in AS::Reloader
Commits on Nov 16, 2017
  1. Merge pull request #31169 from ydakuka/patch-1

    kamipo committed Nov 16, 2017
    Fix links [ci skip]
  2. Fix links [ci skip]

    ydakuka committed Nov 16, 2017
  3. Avoid creating extra `relation` and `build_arel` in `_create_record` …

    kamipo committed Nov 16, 2017
    …and `_update_record` (#29999)
    
    Currently `_create_record` and `_update_record` in `Persistence` are
    creating extra `unscoped` and calling `build_arel` in the relation. But
    `compile_insert` and `compile_update` can be done without those
    expensive operation for `SelectManager` creation. So I moved the
    implementation to `Persistence` to avoid creating extra relation and
    refactored to avoid calling `build_arel`.
    
    https://gist.github.com/kamipo/8ed73d760112cfa5f6263c9413633419
    
    Before:
    
    ```
    Warming up --------------------------------------
          _update_record   150.000  i/100ms
    Calculating -------------------------------------
          _update_record      1.548k (±12.3%) i/s -      7.650k in   5.042603s
    ```
    
    After:
    
    ```
    Warming up --------------------------------------
          _update_record   201.000  i/100ms
    Calculating -------------------------------------
          _update_record      2.002k (±12.8%) i/s -      9.849k in   5.027681s
    ```
    
    30% faster for STI classes.
  4. Merge pull request #27494 from matthewd/executor-guide

    matthewd committed Nov 16, 2017
    Start on a guide for the Executor & Load Interlock
  5. Merge pull request #31166 from freeletics/fix-example

    kaspth committed Nov 16, 2017
    Fixed example of `Rails.application.encrypted` method usage
Commits on Nov 15, 2017
  1. Add master key to `gitignore` on `rails new`

    y-yagi committed Nov 15, 2017
    We generate master key on `rails new`.
    Therefore, if do not add master key to `.gitginore` on `rails new`as
    well, there is a possibility that the master key will be committed
    accidentally.