-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using react-komposer with react-native #38
Comments
I'm also seeing it. Will try to fix. |
@arunoda ok thanks. Let me know if you need any help. Would like to use mantra on a react-native project. |
Yes. We need some help. If you can find the problem and fix it to work on ReactNative, that's super awesome. |
@superandrew213, what do you suspect? |
@smooJitter not sure. Maybe something to do with babel? |
+1 for react-native support |
Has anyone made any progress on this? |
@arunoda could it have something to do with the html tags like: |
Removing the option in .babelrc of react-display-name module does remove the error and mantra-core seems to work. |
@superandrew213 can you explain which option did you removed ? |
@yanivnizry make sure you are using react-display-name v0.0.1. Latest version is using babel 6 and removing the options doesn't work. react-display-name v0.0.1 has two options. Remove them both. |
@superandrew213 thank you. |
Yeah. We can. |
I would love to use Mantra via react-native. I know you guys are busy but it would be nice to at least have a small list of complication that would need to be addressed. This repo ( spencercarli/react-native-meteor-boilerplate) provides a framework for connecting to meteor from a react-native client via node-ddp. I also looked at Kadira React Native Demo with GraphQL, which sounds promising but Apollo is still in early stages. For those considering Meteor + Mantra + React-Native prototypes, It would be nice to have a little direction regarding Mantra compatible client / server technologies to support GraphQL and routing (e.g., react-native-router-flux, exNavigator, ExperimentalNavigation). Furthermore how would "context" configurations change. |
@arunoda it's just a hack. I manually added both mantra-core and react-komposer source into project root dir and imported the manually added react-komposer in mantra-core. After doing that I got the error with react-display-name babel options. So I went into the module and just removed the options. (Note you have to downgrade react-display-name to v0.01 if it is higher. It doesn't work with the new version). |
@superandrew213 Hmm. If that's the issue, let's try to remove |
@arunoda adding Still need to remove Sent you prs. |
That's cool. I'll take this. I'll do a release now and ping you. |
yep removed it already and sent you pr. |
FYI: Updated |
@superandrew213 what are you using for reactivity instead of Tracker ? have you tried https://github.com/aleclarson/tracker |
Not yet but will check it out. Right now I'm using redux. |
For now you can set your own react-native loading and error components like so: https://github.com/kadirahq/react-komposer#change-the-loading-component @arunoda maybe we can use |
Yeah. We should try to detect that and load appropriate Loading components in RN. |
Yes it works, it was added in react-native v0.17.0. However to show react-native views and text components we might need to add react-native as a dependency. |
Can't we simply get that RN Text component? If not, we should try to add RN as a peer-dependancy. |
I'm not sure whether you can get the Text component only. What do you think about this? |
Closing this since, we already support RN. But, we need to provide loading components manually. That's bit of an issue. We could fix this with #8 |
Has anyone gotten this to work? I am trying to use mantra-core with react-native but get the error that mantra core can't load 'react-composer'. Installing react-composer without mantra-core still causes the same issue.
To replicate, create blank react-native app. Install react-composer and import (import {createApp} from 'react-composer';) it in index.ios.js.
I'm getting the following issue. Already tried the following:
The text was updated successfully, but these errors were encountered: