New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.11 fails to build against boost-1.66.0 #2620

Open
Ponce opened this Issue Dec 20, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@Ponce

Ponce commented Dec 20, 2017

libtorrent version (or branch): 1.0.11
platform/architecture: slackware64-current
compiler and compiler version: gcc 7.2.0

as slackware64-current moved to boost-1.66.0, libtorrent-rasterbar-1.0.11 won't build anymore


Type 'make' to compile libtorrent-rasterbar 1.0.11
or type 'make V=1' for verbose compiling
and then 'make install' to install it into /usr

Making all in include/libtorrent
make[1]: Entering directory '/tmp/SBo/libtorrent-rasterbar-1.0.11/include/libtorrent'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/tmp/SBo/libtorrent-rasterbar-1.0.11/include/libtorrent'
Making all in src
make[1]: Entering directory '/tmp/SBo/libtorrent-rasterbar-1.0.11/src'
CXX web_connection_base.lo
In file included from ../include/libtorrent/web_connection_base.hpp:60:0,
from web_connection_base.cpp:38:
../include/libtorrent/peer_connection.hpp:861:15: error: invalid use of incomplete type ‘libtorrent::io_service {aka class boost::asio::io_service}’
io_service::work m_work;
^~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘libtorrent::io_service {aka class boost::asio::io_service}’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/io_service.hpp:54:0,
from ../include/libtorrent/connection_queue.hpp:40,
from ../include/libtorrent/tracker_manager.hpp:62,
from ../include/libtorrent/torrent.hpp:63,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
/usr/include/boost/asio/io_service.hpp:27:20: error: conflicting declaration ‘typedef class boost::asio::io_context boost::asio::io_service’
typedef io_context io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: previous declaration as ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/tracker_manager.hpp:66:0,
from ../include/libtorrent/torrent.hpp:63,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/udp_socket.hpp: In member function ‘libtorrent::io_service& libtorrent::udp_socket::get_io_service()’:
../include/libtorrent/udp_socket.hpp:83:67: error: invalid initialization of reference of type ‘libtorrent::io_service& {aka boost::asio::io_service&}’ from expression of type ‘boost::asio::io_context’
io_service& get_io_service() { return m_ipv4_sock.get_io_service(); }
^
In file included from ../include/libtorrent/torrent.hpp:63:0,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/tracker_manager.hpp: In member function ‘libtorrent::io_service& libtorrent::timeout_handler::get_io_service()’:
../include/libtorrent/tracker_manager.hpp:194:65: error: invalid initialization of reference of type ‘libtorrent::io_service& {aka boost::asio::io_service&}’ from expression of type ‘boost::asio::io_context’
io_service& get_io_service() { return m_timeout.get_io_service(); }
^
In file included from ../include/libtorrent/socks5_stream.hpp:39:0,
from ../include/libtorrent/socket_type.hpp:38,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/proxy_base.hpp: In constructor ‘libtorrent::proxy_base::proxy_base(libtorrent::io_service&)’:
../include/libtorrent/proxy_base.hpp:57:26: error: no matching function for call to ‘boost::asio::basic_stream_socketboost::asio::ip::tcp::basic_stream_socket(libtorrent::io_service&)’
, m_resolver(io_service)
^
In file included from /usr/include/boost/asio/basic_socket_streambuf.hpp:25:0,
from /usr/include/boost/asio/basic_socket_iostream.hpp:24,
from /usr/include/boost/asio/ip/tcp.hpp:20,
from ../include/libtorrent/socket.hpp:61,
from ../include/libtorrent/policy.hpp:42,
from ../include/libtorrent/peer_connection.hpp:71,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
/usr/include/boost/asio/basic_stream_socket.hpp:185:3: note: candidate: template boost::asio::basic_stream_socket::basic_stream_socket(boost::asio::basic_stream_socket&&, typename std::enable_if<std::is_convertible<Rep2, Rep>::value>::type*)
basic_stream_socket(
^~~~~~~~~~~~~~~~~~~
/usr/include/boost/asio/basic_stream_socket.hpp:185:3: note: template argument deduction/substitution failed:
In file included from ../include/libtorrent/socks5_stream.hpp:39:0,
from ../include/libtorrent/socket_type.hpp:38,
from ../include/libtorrent/aux
/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/proxy_base.hpp:57:26: note: ‘libtorrent::io_service {aka boost::asio::io_service}’ is not derived from ‘boost::asio::basic_stream_socket’
, m_resolver(io_service)
^
In file included from /usr/include/boost/asio/basic_socket_streambuf.hpp:25:0,
from /usr/include/boost/asio/basic_socket_iostream.hpp:24,
from /usr/include/boost/asio/ip/tcp.hpp:20,
from ../include/libtorrent/socket.hpp:61,
from ../include/libtorrent/policy.hpp:42,
from ../include/libtorrent/peer_connection.hpp:71,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
/usr/include/boost/asio/basic_stream_socket.hpp:152:3: note: candidate: boost::asio::basic_stream_socket::basic_stream_socket(boost::asio::basic_stream_socket&&) [with Protocol = boost::asio::ip::tcp]
basic_stream_socket(basic_stream_socket&& other)
^~~~~~~~~~~~~~~~~~~
/usr/include/boost/asio/basic_stream_socket.hpp:152:3: note: no known conversion for argument 1 from ‘libtorrent::io_service {aka boost::asio::io_service}’ to ‘boost::asio::basic_stream_socketboost::asio::ip::tcp&&’
/usr/include/boost/asio/basic_stream_socket.hpp:134:3: note: candidate: boost::asio::basic_stream_socket::basic_stream_socket(boost::asio::io_context&, const protocol_type&, const native_handle_type&) [with Protocol = boost::asio::ip::tcp; boost::asio::basic_stream_socket::protocol_type = boost::asio::ip::tcp; boost::asio::basic_stream_socket::native_handle_type = int]
basic_stream_socket(boost::asio::io_context& io_context,
^~~~~~~~~~~~~~~~~~~
/usr/include/boost/asio/basic_stream_socket.hpp:134:3: note: candidate expects 3 arguments, 1 provided
/usr/include/boost/asio/basic_stream_socket.hpp:114:3: note: candidate: boost::asio::basic_stream_socket::basic_stream_socket(boost::asio::io_context&, const endpoint_type&) [with Protocol = boost::asio::ip::tcp; boost::asio::basic_stream_socket::endpoint_type = boost::asio::ip::basic_endpointboost::asio::ip::tcp]
basic_stream_socket(boost::asio::io_context& io_context,
^~~~~~~~~~~~~~~~~~~
/usr/include/boost/asio/basic_stream_socket.hpp:114:3: note: candidate expects 2 arguments, 1 provided
/usr/include/boost/asio/basic_stream_socket.hpp:93:3: note: candidate: boost::asio::basic_stream_socket::basic_stream_socket(boost::asio::io_context&, const protocol_type&) [with Protocol = boost::asio::ip::tcp; boost::asio::basic_stream_socket::protocol_type = boost::asio::ip::tcp]
basic_stream_socket(boost::asio::io_context& io_context,
^~~~~~~~~~~~~~~~~~~
/usr/include/boost/asio/basic_stream_socket.hpp:93:3: note: candidate expects 2 arguments, 1 provided
/usr/include/boost/asio/basic_stream_socket.hpp:76:12: note: candidate: boost::asio::basic_stream_socket::basic_stream_socket(boost::asio::io_context&) [with Protocol = boost::asio::ip::tcp]
explicit basic_stream_socket(boost::asio::io_context& io_context)
^~~~~~~~~~~~~~~~~~~
/usr/include/boost/asio/basic_stream_socket.hpp:76:12: note: no known conversion for argument 1 from ‘libtorrent::io_service {aka boost::asio::io_service}’ to ‘boost::asio::io_context&’
In file included from ../include/libtorrent/socks5_stream.hpp:39:0,
from ../include/libtorrent/socket_type.hpp:38,
from ../include/libtorrent/aux
/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/proxy_base.hpp:57:26: error: no matching function for call to ‘boost::asio::ip::basic_resolverboost::asio::ip::tcp::basic_resolver(libtorrent::io_service&)’
, m_resolver(io_service)
^
In file included from /usr/include/boost/asio/ip/tcp.hpp:25:0,
from ../include/libtorrent/socket.hpp:61,
from ../include/libtorrent/policy.hpp:42,
from ../include/libtorrent/peer_connection.hpp:71,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
/usr/include/boost/asio/ip/basic_resolver.hpp:116:3: note: candidate: boost::asio::ip::basic_resolver::basic_resolver(boost::asio::ip::basic_resolver&&) [with InternetProtocol = boost::asio::ip::tcp]
basic_resolver(basic_resolver&& other)
^~~~~~~~~~~~~~
/usr/include/boost/asio/ip/basic_resolver.hpp:116:3: note: no known conversion for argument 1 from ‘libtorrent::io_service {aka boost::asio::io_service}’ to ‘boost::asio::ip::basic_resolverboost::asio::ip::tcp&&’
/usr/include/boost/asio/ip/basic_resolver.hpp💯12: note: candidate: boost::asio::ip::basic_resolver::basic_resolver(boost::asio::io_context&) [with InternetProtocol = boost::asio::ip::tcp]
explicit basic_resolver(boost::asio::io_context& io_context)
^~~~~~~~~~~~~~
/usr/include/boost/asio/ip/basic_resolver.hpp💯12: note: no known conversion for argument 1 from ‘libtorrent::io_service {aka boost::asio::io_service}’ to ‘boost::asio::io_context&’
In file included from ../include/libtorrent/socks5_stream.hpp:39:0,
from ../include/libtorrent/socket_type.hpp:38,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/proxy_base.hpp: In member function ‘libtorrent::io_service& libtorrent::proxy_base::get_io_service()’:
../include/libtorrent/proxy_base.hpp:227:31: error: invalid initialization of reference of type ‘libtorrent::io_service& {aka boost::asio::io_service&}’ from expression of type ‘boost::asio::io_context’
return m_sock.get_io_service();
^
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp: In member function ‘void libtorrent::utp_stream::async_connect(const endpoint_type&, const Handler&)’:
../include/libtorrent/utp_stream.hpp:271:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, asio::error::operation_not_supported, 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp:277:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, asio::error::not_connected, 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp: In member function ‘void libtorrent::utp_stream::async_read_some(const Mutable_Buffers&, const Handler&)’:
../include/libtorrent/utp_stream.hpp:296:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, asio::error::not_connected, 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp:303:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, asio::error::operation_not_supported, 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp:320:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, error_code(), 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp: In member function ‘void libtorrent::utp_stream::async_write_some(const Const_Buffers&, const Handler&)’:
../include/libtorrent/utp_stream.hpp:415:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, asio::error::not_connected, 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp:422:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, asio::error::operation_not_supported, 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from ../include/libtorrent/socket_type.hpp:41:0,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/utp_stream.hpp:440:4: warning: invalid use of incomplete type ‘class boost::asio::io_service’
m_io_service.post(boost::bind(handler, error_code(), 0));
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘class boost::asio::io_service’
class io_service;
^~~~~~~~~~
In file included from /usr/include/boost/asio/ssl.hpp:22:0,
from ../include/libtorrent/ssl_stream.hpp:41,
from ../include/libtorrent/socket_type.hpp:47,
from ../include/libtorrent/aux_/session_impl.hpp:76,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
/usr/include/boost/asio/ssl/stream.hpp: In instantiation of ‘class boost::asio::ssl::streamlibtorrent::utp_stream’:
../include/libtorrent/ssl_stream.hpp:60:46: required from ‘class libtorrent::ssl_streamlibtorrent::utp_stream’
../include/libtorrent/socket_type.hpp:307:35: required from here
/usr/include/boost/asio/ssl/stream.hpp:85:53: error: no type named ‘executor_type’ in ‘boost::asio::ssl::streamlibtorrent::utp_stream::lowest_layer_type {aka class libtorrent::utp_stream}’
typedef typename lowest_layer_type::executor_type executor_type;
^~~~~~~~~~~~~
In file included from ../include/libtorrent/aux_/session_impl.hpp:78:0,
from ../include/libtorrent/torrent.hpp:75,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/disk_io_thread.hpp: At global scope:
../include/libtorrent/disk_io_thread.hpp:513:31: error: incomplete type ‘libtorrent::io_service {aka boost::asio::io_service}’ used in nested name specifier
boost::optional<io_service::work> m_work;
^~~~
../include/libtorrent/disk_io_thread.hpp:513:31: error: incomplete type ‘libtorrent::io_service {aka boost::asio::io_service}’ used in nested name specifier
../include/libtorrent/disk_io_thread.hpp:513:35: error: template argument 1 is invalid
boost::optional<io_service::work> m_work;
^
In file included from ../include/libtorrent/torrent.hpp:75:0,
from ../include/libtorrent/web_connection_base.hpp:67,
from web_connection_base.cpp:38:
../include/libtorrent/aux_/session_impl.hpp:681:23: error: field ‘m_io_service’ has incomplete type ‘libtorrent::io_service {aka boost::asio::io_service}’
mutable io_service m_io_service;
^~~~~~~~~~~~
In file included from ../include/libtorrent/peer_connection.hpp:82:0,
from ../include/libtorrent/web_connection_base.hpp:60,
from web_connection_base.cpp:38:
../include/libtorrent/io_service_fwd.hpp:59:7: note: forward declaration of ‘libtorrent::io_service {aka class boost::asio::io_service}’
class io_service;
^~~~~~~~~~
make[1]: *** [Makefile:890: web_connection_base.lo] Error 1
make[1]: Leaving directory '/tmp/SBo/libtorrent-rasterbar-1.0.11/src'
make: *** [Makefile:622: all-recursive] Error 1


I've seen a fix pushed for RC_1_1 ( d1a63cd ): is there any plan to push a similar one for RC_1_0?
I'm asking because on slackbuilds.org libtorrent-rasterbar is listed as a dependency for miro, deluge, qbittorrent and tribler and I'm not sure they are all compatible with 1.1.x (please correct me if I'm wrong).

@sledgehammer999

This comment has been minimized.

Show comment
Hide comment
@sledgehammer999

sledgehammer999 Dec 24, 2017

Contributor

I'm not sure they are all compatible with 1.1.x (please correct me if I'm wrong).

As a qbittorrent developer I can say that qbt 4.0.x series is compatible with 1.1.x series(1.1.2+ to be more specific).

Contributor

sledgehammer999 commented Dec 24, 2017

I'm not sure they are all compatible with 1.1.x (please correct me if I'm wrong).

As a qbittorrent developer I can say that qbt 4.0.x series is compatible with 1.1.x series(1.1.2+ to be more specific).

@fshp

This comment has been minimized.

Show comment
Hide comment
@fshp

fshp Jan 9, 2018

@sledgehammer999 as a qbittorrent user i can say that qbt 4.0.x has io error with 1.1.x

fshp commented Jan 9, 2018

@sledgehammer999 as a qbittorrent user i can say that qbt 4.0.x has io error with 1.1.x

@sledgehammer999

This comment has been minimized.

Show comment
Hide comment
@sledgehammer999

sledgehammer999 Jan 9, 2018

Contributor

@sledgehammer999 as a qbittorrent user i can say that qbt 4.0.x has io error with 1.1.x

And how is that related to this bug report? Especially in this foreign bug tracker (aka libtorrent's bug tracker).
qBittorrent bug tracker is here.

Contributor

sledgehammer999 commented Jan 9, 2018

@sledgehammer999 as a qbittorrent user i can say that qbt 4.0.x has io error with 1.1.x

And how is that related to this bug report? Especially in this foreign bug tracker (aka libtorrent's bug tracker).
qBittorrent bug tracker is here.

@fshp

This comment has been minimized.

Show comment
Hide comment
@fshp

fshp Jan 9, 2018

And how is that related to this bug report? Especially in this foreign bug tracker (aka libtorrent's bug tracker).

qbt need this branch. This issue is actually.

fshp commented Jan 9, 2018

And how is that related to this bug report? Especially in this foreign bug tracker (aka libtorrent's bug tracker).

qbt need this branch. This issue is actually.

@arvidn

This comment has been minimized.

Show comment
Hide comment
@arvidn

arvidn Jan 13, 2018

Owner

I would accept a back-port of the boost-1.66 patch into RC_1_0. One thing to keep in mind is that supporting asio from boost-1.66, C++11 is required. in RC_1_1 C++11 is only required when using boost-1.66, otherwise the previous code is used.

Owner

arvidn commented Jan 13, 2018

I would accept a back-port of the boost-1.66 patch into RC_1_0. One thing to keep in mind is that supporting asio from boost-1.66, C++11 is required. in RC_1_1 C++11 is only required when using boost-1.66, otherwise the previous code is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment