Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_copy_file fails on tmpfs #7566

Closed
graywolf opened this issue Nov 30, 2023 · 1 comment
Closed

test_copy_file fails on tmpfs #7566

graywolf opened this issue Nov 30, 2023 · 1 comment

Comments

@graywolf
Copy link

Please provide the following information

libtorrent version (or branch): 2.0.9

platform/architecture: linux/x86_64

When running the test suite, test_copy_file fails since it assumes that tmpfs does not support sparse file, but in fact it does. Adding TMPFS_MAGIC into sparse_filesystems seems to suffice to fix this problem.

But in general I wonder if more robust detection strategy should not be used, the whitelist approach does seem like it has few holes.

@arvidn
Copy link
Owner

arvidn commented Feb 17, 2024

Perhaps, since it's just a test though, it's hard to justify too much effort into making it more robust. But patches are welcome!

Thanks for this, I'll make this change!

#7611

@arvidn arvidn closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants