Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_create_torrent fails when built from the release archive #7567

Closed
graywolf opened this issue Nov 30, 2023 · 1 comment
Closed

test_create_torrent fails when built from the release archive #7567

graywolf opened this issue Nov 30, 2023 · 1 comment

Comments

@graywolf
Copy link

graywolf commented Nov 30, 2023

Please provide the following information

libtorrent version (or branch): v2.0.9 tag
platform/architecture: linux/x86_64

  1. Download https://github.com/arvidn/libtorrent/releases/download/v2.0.9/libtorrent-rasterbar-2.0.9.tar.gz
  2. Build it and try to run test_create_torrent
  3. See this error:
Test #16: test_create_torrent ..............***Failed    0.01 sec
test: /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_create_torrent
cwd_prefix = "/tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_tmp_4305_"
[/tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/libtorrent-rasterbar-2.0.9/test/test_create_torrent.cpp.create_torrent_round_trip_empty_file]

cwd: /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_tmp_4305_8
test-case: /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/libtorrent-rasterbar-2.0.9/test/test_create_torrent.cpp.create_torrent_round_trip_empty_file
rnd = b80473f4

***** /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/libtorrent-rasterbar-2.0.9/test/test_create_torrent.cpp:170 "TEST_ERROR: check failed: "ret == 0"" *****


***** /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/libtorrent-rasterbar-2.0.9/test/test_create_torrent.cpp:171 "TEST_ERROR: check failed: "!ec"" *****


***** /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/libtorrent-rasterbar-2.0.9/test/main.cpp:520 "TEST_ERROR: Terminated with system_error: (3) [bdecode] "unexpected end of file in bencoded string"" *****

Failed to remove unit test directory: No such file or directory

For some reason it looks like test/test_torrents/v2_empty_file.torrent is not part of the source archive. Copying it from the v2.0.9 git tag into the directory extracted from the archive makes the test pass.

@arvidn
Copy link
Owner

arvidn commented Feb 17, 2024

thanks for the report!
#7612

@arvidn arvidn closed this as completed Feb 17, 2024
kostadinsh added a commit to kostadinsh/gentoo that referenced this issue Apr 24, 2024
Reenabled some tests which failed with previous versions, but are fixed
with 2.0.10: test_ssl [1], test_copy_file [2], test_create_torrent [3],
and disabled a test which fails randomly (test_remove_torrent)

[1] arvidn/libtorrent#7565
[2] arvidn/libtorrent#7566
[3] arvidn/libtorrent#7567

Closes: https://bugs.gentoo.org/924415
Closes: https://bugs.gentoo.org/929708
Signed-off-by: Kostadin Shishmanov <kocelfc@tutanota.com>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue May 3, 2024
Reenabled some tests which failed with previous versions, but are fixed
with 2.0.10: test_ssl [1], test_copy_file [2], test_create_torrent [3],
and disabled a test which fails randomly (test_remove_torrent)

[1] arvidn/libtorrent#7565
[2] arvidn/libtorrent#7566
[3] arvidn/libtorrent#7567

Closes: https://bugs.gentoo.org/924415
Closes: https://bugs.gentoo.org/929708
Signed-off-by: Kostadin Shishmanov <kocelfc@tutanota.com>
Closes: #36398
Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants