From 8a1b37ebffa722d5b819cf0d4848a354f6aac644 Mon Sep 17 00:00:00 2001 From: Ari Hartikainen Date: Sat, 10 Jun 2023 11:54:33 +0300 Subject: [PATCH] Add default nopython kwarg (#2246) * Add default nopython kwarg * Add default nopython value to tests * update changelog --------- Co-authored-by: Oriol (ZBook) --- CHANGELOG.md | 3 ++- arviz/tests/base_tests/test_utils_numba.py | 2 +- arviz/utils.py | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d55649c631..45b397331f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,10 +7,11 @@ - Bayes Factor plot: Use arviz's kde instead of the one from scipy ([2237](https://github.com/arviz-devs/arviz/pull/2237)) ### Maintenance and fixes - +- Fix numba deprecation warning ([2246](https://github.com/arviz-devs/arviz/pull/2246)) - Fixes for creating numpy object array ([2233](https://github.com/arviz-devs/arviz/pull/2233) and [2239](https://github.com/arviz-devs/arviz/pull/2239)) - Adapt histograms generated by plot_dist to input dtype ([2247](https://github.com/arviz-devs/arviz/pull/2247)) + ### Deprecation ### Documentation diff --git a/arviz/tests/base_tests/test_utils_numba.py b/arviz/tests/base_tests/test_utils_numba.py index 77845253a7..47fc41ea48 100644 --- a/arviz/tests/base_tests/test_utils_numba.py +++ b/arviz/tests/base_tests/test_utils_numba.py @@ -48,7 +48,7 @@ def placeholder_func(): # pylint: disable=unpacking-non-sequence function_results, wrapper_result = placeholder_func() - assert wrapper_result == {"keyword_argument": "A keyword argument"} + assert wrapper_result == {"keyword_argument": "A keyword argument", "nopython": False} assert function_results == "output" diff --git a/arviz/utils.py b/arviz/utils.py index 6a2aae87ee..ad7359a57f 100644 --- a/arviz/utils.py +++ b/arviz/utils.py @@ -174,6 +174,7 @@ class maybe_numba_fn: # pylint: disable=invalid-name def __init__(self, function, **kwargs): """Wrap a function and save compilation keywords.""" self.function = function + kwargs.setdefault("nopython", False) self.kwargs = kwargs @lazy_property