Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor checkUtils: remove repeating commands #82

Merged
merged 2 commits into from Oct 27, 2019

Conversation

@4ndrej
Copy link
Contributor

4ndrej commented Oct 25, 2019

putting checked utils into array and running through the array in for loop cleans the code

putting checked utils into array and running through the array in for loop cleans the code
@arzzen arzzen requested a review from tomice Oct 25, 2019
@tomice

This comment has been minimized.

Copy link
Collaborator

tomice commented Oct 25, 2019

Much cleaner! Looks very good. Could you please add the -r flag to the utils variable to make it readonly as well i.e. declare -ar foo=("bar" "baz")

@4ndrej

This comment has been minimized.

Copy link
Contributor Author

4ndrej commented Oct 25, 2019

changed to read only array

@tomice

This comment has been minimized.

Copy link
Collaborator

tomice commented Oct 25, 2019

Nice, thanks! LGTM

@arzzen arzzen merged commit dc72bab into arzzen:master Oct 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arzzen

This comment has been minimized.

Copy link
Owner

arzzen commented Oct 27, 2019

Thanks for your contribution @4ndrej

@4ndrej 4ndrej deleted the 4ndrej:patch-1 branch Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.