Antonio Scandurra
as-cii

Organizations

@github @atom
Jul 22, 2016
@as-cii
Jul 22, 2016
@as-cii
as-cii created tag v1.12.3 at atom/apm
Jul 22, 2016
Jul 22, 2016
as-cii pushed to master at atom/apm
@as-cii
Jul 22, 2016
as-cii pushed to master at atom/apm
@as-cii
as-cii deleted branch as-fix-missing-flags at atom/apm
Jul 22, 2016
Jul 22, 2016
as-cii merged pull request atom/apm#596
@as-cii
Fix missing and hardcoded flags
3 commits with 9 additions and 2 deletions
Jul 22, 2016
as-cii commented on pull request atom/tree-view#833
@as-cii

This looks good to me, although I am wondering: is the Directory object public? Seems like a private method of this package, which makes me somewha…

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

I think that file is meant to test FileIcons without involving the UI, and just assert that it can be configured properly. This one seems more like…

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

That would be 🆒! How about avoiding to pass this in the current pull-request and open a new one with the new config parameter?

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

Are you referring to @fileName.classList.add(iconClass…)? I think the trailing will work fine, adding first and second appropriately, without com…

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

Interesting, I wonder if we should put that setting on the individual packages instead of customizing every package UI via File-Icons. Both tree-vi…

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

What about moving this spec into tree-view-spec.coffee? Testing the interaction between FileView and the file icon service seems to belong more to …

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

Seems like we could remove this newline 🔥

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

💡 What do you think about slightly changing this into: if Array.isArray(iconClass) @fileName.classList.add(iconClass…) else @fileName.classList.add(…

Jul 22, 2016
as-cii commented on pull request atom/tree-view#825
@as-cii

Could you explain why we need to pass the current FileView instance to the file icons service? Maybe it's not a huge deal, but seems like the servi…

Jul 22, 2016
@as-cii
  • @as-cii a5d4676
    Add leftover --runtime=electron flag
Jul 22, 2016
as-cii opened pull request atom/apm#596
@as-cii
Fix missing and hardcoded flags
2 commits with 8 additions and 2 deletions
Jul 22, 2016
Jul 22, 2016
as-cii commented on issue atom/atom#12085
@as-cii

Does it happen after you change the file? If so, can you help us tracking down which kind of edit triggers the exception? My sense is that, somehow…

Jul 21, 2016
@as-cii
Jul 21, 2016
@as-cii
Jul 21, 2016
as-cii commented on issue atom/atom#12085
@as-cii

Thanks for your feedback, @flxsource! 🙇 Could you paste the content of that file here so that we can debug this? It seems like that file is causing…

as-cii created tag v1.12.2 at atom/apm
Jul 21, 2016
Jul 21, 2016
as-cii pushed to master at atom/apm
@as-cii
as-cii deleted branch as-disable-npm-progress at atom/apm
Jul 21, 2016
Jul 21, 2016
as-cii pushed to master at atom/apm
@as-cii
Jul 21, 2016
as-cii merged pull request atom/apm#595
@as-cii
Disable progress when running npm
2 commits with 2 additions and 1 deletion
Jul 21, 2016
as-cii commented on pull request atom/apm#595
@as-cii

I have added a comment within .apmrc explaining why we're disabling progress report. I was unclear on whether we should have just added it to apm.c…

Jul 21, 2016
@as-cii
  • @as-cii d686872
    📝 Explain `progress = false`