Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0 introduces conflict with runloop #14

Open
asakusuma opened this issue Jul 28, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@asakusuma
Copy link
Owner

commented Jul 28, 2017

In 0.2.0, we now use the native intersection observer when available. The problem is that the polyfill plays nicely with the Ember runloop, whereas the native intersection observer knows nothing about the Ember runloop. Likely we need to change the API so that Watcher and SpanielObserver will wrap callbacks in the runloop, but IntersectionObserver does not.

asakusuma added a commit that referenced this issue Aug 4, 2017

Release 0.3.0
Address #14 for the
time being. Pulls in memory leak fixes backported spaniel 2.x
@asakusuma

This comment has been minimized.

Copy link
Owner Author

commented Aug 5, 2017

0.3.0 reverts back to spaniel 2.x, which reverts back to the old behavior of always wrapping in a runloop. Keeping this open until we move to using the native IntersectionObserver when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.