Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: responsive layout #32

Closed
jgravois opened this issue Dec 14, 2018 · 13 comments
Closed

enhancement: responsive layout #32

jgravois opened this issue Dec 14, 2018 · 13 comments

Comments

@jgravois
Copy link
Contributor

@jgravois jgravois commented Dec 14, 2018

greetings! 馃憢

first of all, thank you. i've been using freehub happily for many years, first at the Sacramento Bike Kitchen and later at BikeBBQ in Redlands.

  1. awhile back i helped bootstrap another nearby coop called the San Bernardino Bicycle Hubitat. a volunteer who i'm no longer in touch with created an account on https://freehub.bikekitchen.org and used hubitat as the username and subdomain. i'm under the impression that it was never actually put to use. i understand if its not possible, but if there is a way to associate that username with a new email and password, i'd be much obliged.

  2. how can i make a financial contribution on behalf of our bike coop to help y'all keep the lights on?

  3. how would y'all feel about a PR that makes the application easier to navigate on a mobile device?

@asalant
Copy link
Owner

@asalant asalant commented Dec 31, 2018

Hi John! I just found your message buried in my inbox. I'll respond to you with details shortly.

@jgravois
Copy link
Contributor Author

@jgravois jgravois commented Mar 28, 2019

@asalant I ended up just creating another account instead of trying to recover the first one.

i've got a staff member using a phone as the primary device for signing folks in so I'm still keen to PR some new CSS that makes the application easier to navigate on small screens if there's any chance of it actually landing.

@asalant
Copy link
Owner

@asalant asalant commented Mar 28, 2019

@jgravois
Copy link
Contributor Author

@jgravois jgravois commented Mar 28, 2019

no worries at all. enjoy the time AFK.

i'll take a stab at setting up the development environment and laying out the application using css-grid sometime soon.

@jgravois jgravois changed the title how to recover an account when you don't know the password used when it was created enhancement: responsive layout Mar 28, 2019
@fspc
Copy link

@fspc fspc commented Mar 29, 2019

@jgravois , there is a Dockerfile at https://github.com/fspc/freehub that could help you setup a development environment.

For simplicity, supervisord runs mysql and freehub in the same container, although that could easily be accomplished in separate containers without supervisord.

@asalant
Copy link
Owner

@asalant asalant commented Mar 30, 2019

@jgravois
Copy link
Contributor Author

@jgravois jgravois commented Apr 1, 2019

thanks for the pointer @fspc. i was able to set up a local development environment (with hardly any docker experience) by:

  1. pulling down and running your handy container
  2. git cloneing asalant/freehub
  3. using onchange to copy/paste the contents of the cloned repo into the same location in the container each time i touch a file.
onchange '**/*' -- docker cp . freehub:/freehub

@fspc
Copy link

@fspc fspc commented Apr 4, 2019

@jgravois, good to hear, and a cool use of onchange!

thanks for the pointer @fspc. i was able to set up a local development environment (with hardly any docker experience) by:

  1. using onchange to copy/paste the contents of the cloned repo into the same location in the container each time i touch a file.
onchange '**/*' -- docker cp . freehub:/freehub

@asalant
Copy link
Owner

@asalant asalant commented Dec 2, 2019

Hi @jgravois! Just an FYI that I have some time to dedicate to Freehub and am working on a couple updates.

First is purely backend - I've got to do some hosting and infrastructure changes by Jan 1 as requested by our provider Engine Yard who has been providing pro bono hosting.

But once that is done, responsive layouts to make it easy to use Freehub on phones is my top priority. Let me know if you've made any progress there or want to collaborate.

@fspc I'll be trying to work with your Docker config too.

@jgravois
Copy link
Contributor Author

@jgravois jgravois commented Dec 2, 2019

I have some time to dedicate to Freehub and am working on a couple updates.

very cool!

after I got things up and running locally and played around with the .css a bit I promptly had a new baby 馃懚 and set the whole project aside.

its funny that you mention it though, because this thanksgiving break I made a promise to myself to pick this back up and chip away at it a little at a time so I am definitely game to collaborate.

the first time around I thought it'd be clever (and helpful) to make a lot less extensive use of ids and use classnames instead.

The more I thought about it though, the more I realized that I'd probably be better off leaving the backend alone (for now). to keep me honest on that front my new plan has been to just save static .html from the live site and start building up a new .css file one page at a time

  • homepage
  • /:org
  • /:org/visits
  • etc.

how would you feel about doing it that way? if so, I'll plan on saving some boilerplate in a new public repo of my own and inviting you as a collaborator.

@asalant
Copy link
Owner

@asalant asalant commented Dec 2, 2019

@jgravois
Copy link
Contributor Author

@jgravois jgravois commented Dec 2, 2019

I'm a big fan of releasing code to production as it is worked on but in a
way that does not force users to use it until it is ready.

that sounds good to me, but it may get a bit sticky trying to load both the new .css and old .css simultaneously. another option would be to (temporarily) host http://responsive-freehub.bikekitchen.org and try to gather feedback from users for a few weeks before flipping the switch for real.

I'm hopeful that most users are already running a modern browser. if it turns out that a significant number can't/aren't, we'll have to account for that.

let's prioritize the views by where a responsive layout will deliver the most value.

that makes a ton of sense, for us that would be the staff login and customer sign in pages. I'll start playing around with them first.

@jgravois
Copy link
Contributor Author

@jgravois jgravois commented Jan 15, 2020

done in #43 馃帀馃殌:shipit:

I'll be able to collect some feedback from my San Bernardino Bicycle Hubitat user over the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants