Proposed fix for threading issue #3

Merged
merged 1 commit into from Jul 12, 2012

Conversation

Projects
None yet
3 participants
@rshallit

This should fix the issue I brought up.

asanghi added a commit that referenced this pull request Jul 12, 2012

Merge pull request #3 from rshallit/master
Proposed fix for threading issue

@asanghi asanghi merged commit 814c56a into asanghi:master Jul 12, 2012

@asanghi

This comment has been minimized.

Show comment Hide comment
@asanghi

asanghi Jul 12, 2012

Owner

thanks. will push a release out later today.

Owner

asanghi commented Jul 12, 2012

thanks. will push a release out later today.

@stellard

This comment has been minimized.

Show comment Hide comment
@stellard

stellard Nov 1, 2012

Is there a better solution for this? I understand the desire for this fix however I wouldn't describe it as a bug, this is a new feature that has now removed the ability to isolate the financial year between threads.

This is especially an issue if using this in a rails app as different clients might have different financial years...

stellard commented Nov 1, 2012

Is there a better solution for this? I understand the desire for this fix however I wouldn't describe it as a bug, this is a new feature that has now removed the ability to isolate the financial year between threads.

This is especially an issue if using this in a rails app as different clients might have different financial years...

@asanghi

This comment has been minimized.

Show comment Hide comment
@asanghi

asanghi Nov 1, 2012

Owner

Perhaps allow users to set a global process wide setting and then allow them to override it in a thread? Feel free to send thru a patch if you're in a rush.

Owner

asanghi commented Nov 1, 2012

Perhaps allow users to set a global process wide setting and then allow them to override it in a thread? Feel free to send thru a patch if you're in a rush.

@asanghi

This comment has been minimized.

Show comment Hide comment
@asanghi

asanghi Nov 2, 2012

Owner

Thinking a bit more about this, i'm inclined to deal with it like Time.in_fiscal_zone(your_fiscal_zone,&block) to allow usage within a specific context/thread.

Owner

asanghi commented Nov 2, 2012

Thinking a bit more about this, i'm inclined to deal with it like Time.in_fiscal_zone(your_fiscal_zone,&block) to allow usage within a specific context/thread.

@stellard

This comment has been minimized.

Show comment Hide comment
@stellard

stellard Nov 2, 2012

Yea thats actually a much better idea. Much more clear of its intention. Would integrate well with Rails too.

stellard commented Nov 2, 2012

Yea thats actually a much better idea. Much more clear of its intention. Would integrate well with Rails too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment