Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better if the error prompt is more friendly #54

Closed
kkew3 opened this Issue Dec 19, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@kkew3
Copy link

kkew3 commented Dec 19, 2018

Before I carefully went through the manual, I attempted to set the width only by boxes -s 70x. Apparently it would fail, but with prompt:

boxes: box size: Interrupted system call, '70x'

I believe it might be better to show a more friendly prompt when there's parsing error with option string, with something like "boxes: box size: illegal option string", for example. Thanks!

boxes version: 1.2.

@tsjensen

This comment has been minimized.

Copy link
Member

tsjensen commented Dec 19, 2018

Dang, this works for me! → echo foo | boxes -s 70x:

/********************************************************************/
/* foo                                                              */
/********************************************************************/

I agree it's kind of a gray area if this should be possible, but you deserve a better error message! 😉

What system are you on? Are you using a particular binary? How did you install it?

@kkew3

This comment has been minimized.

Copy link
Author

kkew3 commented Dec 19, 2018

Thanks for your reply. I'm on mac OS Majove Version 10.14.1 (18B75). I installed by brew install boxes.

@tsjensen

This comment has been minimized.

Copy link
Member

tsjensen commented Dec 19, 2018

Is it 32bit or 64bit?

(I don't have direct access to a Mac, but I'll try to get a colleague to try your case. It may take some time though, as everybody is on Christmas vacation currently.)

@kkew3

This comment has been minimized.

Copy link
Author

kkew3 commented Dec 19, 2018

It's 64bit.

Thanks. No problem. It should be written as -s 70 anyway, as per the manual.

tsjensen added a commit that referenced this issue Feb 19, 2019

@tsjensen

This comment has been minimized.

Copy link
Member

tsjensen commented Feb 21, 2019

It turned out I didn't get access to a Mac, but I believe I fixed it by looking closely at the code.
Do give it a try. I feel confident enough to close this. Let me know if it turned out ok. 😉
Be sure to test using boxes 1.3.

@tsjensen tsjensen closed this Feb 21, 2019

@kkew3

This comment has been minimized.

Copy link
Author

kkew3 commented Feb 21, 2019

Thanks! The latest version of boxes on brew is 1.2. I'll try it out when 1.3 is available.

@kkew3

This comment has been minimized.

Copy link
Author

kkew3 commented Mar 12, 2019

It works perfectly now. Thanks!

prompt> echo hello | boxes -s 70x
boxes: invalid box size specification -- 70x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.