New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mermaid.cli #163

Closed
pepijnve opened this Issue Sep 14, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@pepijnve
Copy link
Contributor

pepijnve commented Sep 14, 2017

The mermaid CLI has been giving import errors since 7.0.12 and has been removed entirely in 7.1.0. It was replaced by the mermaid.cli package which provides the mmdc command. Unfortunately the supported command line parameters are completely different.
See if there's a way to add support for mmdc as well while still retaining backwards compatibility with the set of block attributes that the mermaid extension currently supports.

@pepijnve

This comment has been minimized.

Copy link
Contributor Author

pepijnve commented Oct 31, 2017

Yep, that's the spot where the logic would need to go. The problem is mmdc doesn't support parameters like css, ganttConfig, ... Ideally I would like the underlying CLI version to be transparent to the asciidoctor-diagram user, but that might simply not be feasible.

@pepijnve pepijnve added this to the 1.5.8 milestone Feb 24, 2018

@pepijnve pepijnve self-assigned this Feb 24, 2018

@pepijnve

This comment has been minimized.

Copy link
Contributor Author

pepijnve commented Feb 24, 2018

Starting with mermaid.cli 0.2.1 (I think) the necessary CLI options became available that allow adding support for mmdc in a way that's backwards compatible with the old CLI interface.
I'll integrate this and add support for the extended option list that mmdc supports (theme, background, full config file, ...)

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

pepijnve added a commit that referenced this issue Feb 24, 2018

@pepijnve pepijnve closed this Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment