Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source trees should report all language source sets (#401) #402

Merged
merged 2 commits into from Jun 16, 2019

Conversation

@ysb33r
Copy link
Member

@ysb33r ysb33r commented Jun 16, 2019

getSourceFileTree and getSecondarySourceFileTree now reports all of the source sets when
multiple languages are specified. This fix distinguishes between classic behaviour and
multi-language behaviour and will either return a single source set of a combination of source sets.

Credits to @ixchelruiz for helping to diagnose this problem at Hack.Commit.Push 2019.

@ysb33r ysb33r added this to the 3.0.0 milestone Jun 16, 2019
@ysb33r ysb33r self-assigned this Jun 16, 2019
@ysb33r ysb33r mentioned this pull request Jun 16, 2019
24 tasks
`getSourceFileTree` and `getSecondarySourceFileTree` now reports all of the source sets when
multiple languages are specified. This fix distinguishes between classic behaviour and
multi-language behaviour and will either return a single source set of a combination of source sets.

Credits to @ixchelruiz for helping to diagnose this problem at Hack.Commit.Push 2019.
@ysb33r ysb33r force-pushed the development-3.x branch from 6195a89 to 5c75bf3 Jun 16, 2019
@coveralls
Copy link

@coveralls coveralls commented Jun 16, 2019

Coverage Status

Coverage increased (+0.04%) to 87.845% when pulling 5c75bf3 on ysb33r:development-3.x into a987e81 on asciidoctor:development-3.x.

Loading

@ysb33r ysb33r merged commit 043f22b into asciidoctor:development-3.x Jun 16, 2019
0 of 2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants