New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font icons for source code callouts #54

Closed
antoyo opened this Issue Nov 6, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@antoyo
Copy link

antoyo commented Nov 6, 2015

Hello.
The font icons for source code callouts (<1>, for instance) does not exist in the reveal.js backend.
Could you add them, please?
Thanks.

@obilodeau

This comment has been minimized.

Copy link
Member

obilodeau commented Aug 26, 2016

Can you provide a minimal example that would reproduce the problem? Thanks!

@antoyo

This comment has been minimized.

Copy link

antoyo commented Aug 26, 2016

Yes.
Here is the code:

= Presentation
Me
:backend: revealjs
:icons: font
:source-highlighter: highlightjs

== Callout

[source, rust]
----
fn main() {
    println!("Hello World!"); // <1>
}
----
<1> `println!` is a macro.

The result:
img-2016-08-26-080038
And the expected result is to have icons similar to the HTML5 backend:
img-2016-08-26-080048

@obilodeau obilodeau removed the need info label Aug 27, 2016

@obilodeau

This comment has been minimized.

Copy link
Member

obilodeau commented Aug 27, 2016

With reveal.js 3.3.0 I think we are closer (uses highlight.js 9 which I think supports callouts):

adoc-callout

However, there might be something needed on our end in order to avoid escaping the HTML (or something like that).

Also tested with coderay, pygments and rouge. Nothing works.

@mojavelinux

This comment has been minimized.

Copy link
Member

mojavelinux commented Aug 30, 2016

It's important to note that the appearance of the callout in built-in HTML backend is provided exclusively by CSS. The screenshot @antoyo posted is exactly what you'd expect if CSS is not helping. The built-in stylesheet in Asciidoctor transforms the <i> element into an enclosed number using CSS. There's no special thing that the converter does.

@obilodeau

This comment has been minimized.

Copy link
Member

obilodeau commented Aug 30, 2016

Good to know. I'll add this to the list of CSS that we need to pull in from asciidoctor.

@obilodeau obilodeau modified the milestone: 1.2.0 Aug 29, 2017

@obilodeau

This comment has been minimized.

Copy link
Member

obilodeau commented Nov 16, 2018

Fixed by #224. See also #168. Will be part of our next release.

@obilodeau obilodeau closed this Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment