Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use lowercase asciidoc attributes #267

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@bentolor
Copy link
Contributor

bentolor commented Jun 26, 2019

Asciidoctor currently does only support/expect attributes to be
in lower case. Unfortunately the code expected attributes like
ealjs_defaultTiming which were never actually resolved and
always provided the default value

@bentolor

This comment has been minimized.

Copy link
Contributor Author

bentolor commented Jun 26, 2019

The failure is out of my control

The requested url does not exist(22): 'https://repo1.maven.org/maven2/org/jruby/jruby-dist/9.2.6.0/jruby-dist-9.2.6.0-bin.tar.gz?rvm=1.29.8'

@ebousse

This comment has been minimized.

Copy link

ebousse commented Aug 9, 2019

hi! any progress regarding this PR by any chance? asciidoctor-reveal.js is a little difficult to use without this fix, unfortunately.

thanks and good luck :)

Copy link
Member

obilodeau left a comment

Good catch! We will probably have to do a bugfix release due to the importance of this bug.

I wish I saw it earlier, I have been really busy...

One comment to address, please.

test/doctest/revealjs-features.html Show resolved Hide resolved
Asciidoctor currently does only support/expect attributes to be
in lower case. Unfortunately the code expected attributes like
ealjs_defaultTiming which were never actually resolved and
always provided the default value
@bentolor bentolor force-pushed the bentolor:fix/broken-attribute-casing branch from 06ecf94 to 134bf3d Dec 3, 2019
@bentolor

This comment has been minimized.

Copy link
Contributor Author

bentolor commented Dec 3, 2019

Rebased to retrigger build with false-positive build failure: Now everything green

@obilodeau obilodeau merged commit 1eddb23 into asciidoctor:master Dec 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.