Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow preload attribute to be set on video HTML5 element #2046

Closed
thom4parisot opened this issue Feb 27, 2017 · 2 comments
Closed

Allow preload attribute to be set on video HTML5 element #2046

thom4parisot opened this issue Feb 27, 2017 · 2 comments
Assignees
Milestone

Comments

@thom4parisot
Copy link
Member

Hello,

asciidoc(tor) doc mentions the ability to use options to provide some additional video::[] macro options but it seems the HTML preload attribute to be missing.

I am willing to generate a <video src="..." preload="metadata"></video> tag in the end. buffered can be nice to control how much a user would download on his end.

Cf. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video#Attributes

Any thoughts?

@thom4parisot thom4parisot changed the title Allow video[preload] preload attribute Allow video[preload] attribute Feb 27, 2017
@mojavelinux
Copy link
Member

We can certainly add this support. It seems to me like it should be an attribute (key/value pair) since it accepts multiple values.

Also, is "auto" the right default or should we use a different value?

@mojavelinux mojavelinux added this to the v1.5.6 milestone Feb 27, 2017
@mojavelinux mojavelinux self-assigned this Feb 27, 2017
@thom4parisot
Copy link
Member Author

If no value is provided for preload, indeed it should be understood as auto.

If no preload attribute is added to the video element, it is already understood as being auto.

@mojavelinux mojavelinux changed the title Allow video[preload] attribute Allow preload attribute to be set on video HTML5 element Mar 30, 2017
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Mar 30, 2017
@mojavelinux mojavelinux removed the next label Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants