New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor link detection to be more robust #281

Open
mojavelinux opened this Issue Apr 26, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@mojavelinux
Member

mojavelinux commented Apr 26, 2013

Currently, the link matching is being performed by two regular expressions that are trying to handle entirely too many cases. Rework the detection so that it's more robust against special characters at the end of links that should not be part of the link. Otherwise, we'll be playing whack-a-mole trying to deal with all the special cases that arise.

@mojavelinux

This comment has been minimized.

Member

mojavelinux commented Apr 26, 2013

As reported by @davidfavor:

When a link exists in parens - (for example http://foo.com), then the trailing ')' is rendered inside both the href + link text.

@mojavelinux

This comment has been minimized.

Member

mojavelinux commented Apr 26, 2013

There is also a case in the AsciiDoc User Guide where this fails:

...for example (from http://www.808.dk/?code-html-5-video):

@mojavelinux mojavelinux modified the milestones: v1.5.1, v1.6.0 Sep 18, 2014

@mojavelinux mojavelinux modified the milestones: v1.6.0, v1.7.0 Dec 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment