Skip to content

/ asciidoctor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop DocBook 4.5 converter #3005

Closed
mojavelinux opened this issue Jan 9, 2019 · 1 comment
Closed

Drop DocBook 4.5 converter #3005

mojavelinux opened this issue Jan 9, 2019 · 1 comment
Assignees
@mojavelinux
Labels
infrastructure
Milestone
v2.0.0

Comments

@mojavelinux
Copy link
Member

@mojavelinux mojavelinux commented Jan 9, 2019

I'd like to drop the built-in DocBook 4.5 converter going into Asciidoctor 2.0.

Keep in mind, this is just about dropping the converter as a built-in feature of core. Asciidoctor allows converters to be developed and loaded independently. So if there's still a strong need to generate DocBook 4.5 using Asciidoctor 2.0, it's possible to take the code from 1.5.8 and create a dedicated converter out of it (perhaps which still extends the DocBook 5 converter).

We just won't be shipping the DocBook 4.5 converter with the core gem any longer.
@mojavelinux mojavelinux added this to the v2.0.0 milestone Jan 9, 2019
@mojavelinux mojavelinux self-assigned this Jan 9, 2019
@Mogztter Mogztter mentioned this issue Feb 3, 2019
Merged
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 4, 2019
@mojavelinux
resolves asciidoctor#3005 remove the converter for the docbook45 backend
b4df664 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
@mojavelinux mojavelinux mentioned this issue Feb 4, 2019
Merged
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 5, 2019
@mojavelinux
resolves asciidoctor#3005 remove the converter for the docbook45 backend
f83681d 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 5, 2019
@mojavelinux
resolves asciidoctor#3005 remove the converter for the docbook45 backend
7c7fd9b 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 5, 2019
@mojavelinux
resolves asciidoctor#3005 remove the converter for the docbook45 backend
7ee78af 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 5, 2019
@mojavelinux
resolves asciidoctor#3005 remove the converter for the docbook45 backend
ab5a069 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 5, 2019
@mojavelinux
resolves asciidoctor#3005 remove the converter for the docbook45 backend
52e6b26 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
@mojavelinux
Copy link
Member Author

@mojavelinux mojavelinux commented Feb 5, 2019

Keep in mind the DocBook 4.5 specification is over 12 years old, and DocBook 5 became a specification over 10 years ago.
mojavelinux added a commit that referenced this issue Feb 5, 2019
@mojavelinux
resolves #3005 remove the converter for the docbook45 backend (PR #3040)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
21f67d3 
- remove the DocBook45Converter class
- remove accomodations in DocBook5Converter for DocBook 4.5
- don't register the docbook45 backend name in the converter registry
- drop docbook45 from the backend CLI option values
- don't mention DocBook 4.5 in the man page
- don't mention DocBook 4.5 in the CLI usage statement
- update tests to use DocBook 5 instead of DocBook 4.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
infrastructure
Projects
None yet
Milestone
v2.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

resolves #3005 remove the converter for the docbook45 backend
1 participant
@mojavelinux
You can’t perform that action at this time.