Implement support for rouge-linenums-mode (add inline mode)

[hepabolu]

I'm using asciidoctor 2.0.10 to generate HTML. I use Rouge for syntax highlighting.

According to https://asciidoctor.org/docs/user-manual/#rouge I should use

:rouge-linenums-mode: inline

for sourceblocks that have long lines. However, that option doesn't seem to work. It doesn't make any difference if I use 'table' or 'inline'.

In both cases the codeblock renders as a table with 2 cells, one containing a '

' tag with all the line numbers, one with the lines as spans wrapped in 1 '
' tag.

On a large block of long lines the linenumbers end way earlier than the actual lines.
This code: https://rouge-ruby.github.io/docs/Rouge/Formatters/HTMLLineTable.html suggests there should be a row with a linenumber + source code line per line.
But that class is never used in https://github.com/asciidoctor/asciidoctor/blob/master/lib/asciidoctor/syntax_highlighter/rouge.rb
I'm not good in Ruby, so I might be overlooking something. If so, please let me know.

[mojavelinux]

Please provide a sample listing block that isn't working properly.

FYI, Asciidoctor does not use the table and line formatters provided by Rouge. Instead, we use the ones from here: https://github.com/asciidoctor/asciidoctor/blob/master/lib/asciidoctor/rouge_ext.rb

[mojavelinux]

Aha! Asciidoctor does not currently support modifying the linenums mode in Rouge, so you're correct that this setting has no effect.

[mojavelinux]

The formatter class you linked to was added to Rouge after the last release of Asciidoctor: https://github.com/rouge-ruby/rouge/commits/master/lib/rouge/formatters/html_line_table.rb

[mojavelinux]

I updated the docs to reflect that this attribute is not yet supported.

[mojavelinux]

For the sake of keeping the styles aligned with the default stylesheet, we'll probably need to implement our own formatter...or at least tune the settings of the one provided by Rouge.

[keryell]

I am involved in a project where we are migrating a big specification document from LaTeX to AsciiDoctor with a lot of source code formatting and tables (https://www.khronos.org/registry/SYCL/specs/sycl-2020-provisional.pdf).
I am still fighting to have source highlighting working correctly both in HTML and PDF with line numbers.
While the discussion in asciidoctor/asciidoctor-pdf#224 (comment) proposes to go with rouge for the PDF side, it looks like inline mode for rouge does not work yet in asciidoctor targeting HTML.
By looking at asciidoctor around lib/asciidoctor/syntax_highlighter.rb, it is not clear to me how far we are from having :rouge-linenums-mode: inline working ...

[mojavelinux]

This issue is about table mode, but your comment mentions inline mode. Do you mean table mode?

Can you elaborate on how you're "still fighting to have source highlighting working correctly". What is not working? If this is a new issue, can you please open a new issue?

[keryell]

What I mean is that I would like to have :rouge-linenums-mode: inline working too, as suggested at the start of this issue.
It is not a new issue, just asking about the status of this feature.