Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated font-awesome CDN refs to 4.2.0, adding 40 new icons #1201

Closed
wants to merge 1 commit into from

Conversation

clojens
Copy link

@clojens clojens commented Nov 20, 2014

As mentioned, changes to the html5 renderer to reflect latest version adding 40 new icons available to the inline icon macro. See here for an overview of how the icons look and what the names are (and consequently how they can be called from asciidoc ;)

Also updated the references in unit tests.

@ggrossetie
Copy link
Member

Hello @clojens, thanks for your contribution.
Can you please remove .un~ files ?

@mojavelinux
Copy link
Member

Have there been any deprecations or changes in Font Awesome name mappings
we need to mention? If not, full stream ahead!

@mojavelinux mojavelinux self-assigned this Nov 20, 2014
@mojavelinux mojavelinux added this to the v1.5.2 milestone Nov 20, 2014
@mojavelinux
Copy link
Member

Looks like we're good! I'll cleanup the files when I merge.

mojavelinux added a commit that referenced this pull request Nov 20, 2014
@mojavelinux
Copy link
Member

Merged!

@mojavelinux
Copy link
Member

Thanks @clojens!

@mojavelinux mojavelinux changed the title Updated font-awesome CDN refs bump 4.2.0 adding 40 new icons Updated font-awesome CDN refs to 4.2.0, adding 40 new icons Nov 20, 2014
@clojens
Copy link
Author

clojens commented Nov 21, 2014

@mojavelinux sorry about the .un files, thanks for cleaning up after me. That is something new I've suddenly experienced, these files, guess resulting from tweaking vim persistent history/undo. I should probably mske vim to store those inside my ~ somewhere centrally.

@mojavelinux
Copy link
Member

@clojens no worries.

Here's what I do to centralize my swap files in vim.

set dir=~/.vim/tmp//  " directory where the swap file is stored (trailing double slash enables full-qualified file name)
set bdir=~/.vim/tmp  " directory where the backup file is temporarily stored

@clojens
Copy link
Author

clojens commented Nov 21, 2014

Right so I just learned ;) Cheers.

@jirutka
Copy link
Member

jirutka commented Nov 21, 2014

BTW, centralized undodir is also very useful. 😸

if exists("+undofile")
  " This allows you to use undos after exiting and restarting.
  " It uses .vim-undo/ with fallback to ~/.vim/undo/ when prior doesn't exist.
  " :help undo-persistence; only present in 7.3+!
  if isdirectory($HOME . '/.vim/undo') == 0
    :silent !mkdir -p ~/.vim/undo > /dev/null 2>&1
  endif
  set undodir=./.vim-undo//
  set undodir+=~/.vim/undo//
  set undofile
endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants