Take in account SOURCE_DATE_EPOCH when testing against timezones #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2018
|
Thanks! I had not thought about the tests running in the reproducible build environment. Thanks for catching this. |
mojavelinux
requested changes
Nov 27, 2018
|
I'm so sorry, your answers totally slipped through the cracks. |
|
Thanks! |
|
Really nice catch, btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just lost 3 hours trying to figure out why, when running in a reproducible build environment, this timezone test was failing. Silly me! 馃槅
Anyway, this patch allows you to run the tests properly in a reproducible builds environment (aka with
SOURCE_DATE_EPOCHset).