fix pom generation for release versions to prevent adding a pom packaging tag #482

Merged
merged 4 commits into from Jul 16, 2016

Projects

None yet

4 participants

@ancho
Contributor
ancho commented Jul 14, 2016

fixes #481

@ancho ancho remove packaging tag to fallback to default type 'jar'
fixes #481
06e9e6a
@robertpanzer
Member

I am inclined to merge this.
The Java7 build failed on Appveyor for no apparent reason, there are not even log files.
The OracleJDK builds passed on Travis (OpenJDK fails already for a longer time, there's a problem in the Travis machine setup).
The travis build tries to also build against the next dev version of asciidoctor, which would be 1.5.5.dev. As this is not available the second build fails after the first successful build.

@ancho
Contributor
ancho commented Jul 14, 2016

Pleas wait. There is a fileSpec variant to add custom files to the bintray repository. If it works we have a cleaner version without manipulating the pom.

@ancho ancho copy signed pom with a fileSpec to bintray. skip.signing fixes.
dd4a0dc
@ancho ancho changed the title from remove packaging tag to fallback to default type 'jar' to fix pom generation for release versions to prevent adding a pom packaging tag Jul 14, 2016
@ancho
Contributor
ancho commented Jul 14, 2016 edited

Here we go. This should do the trick. Tested with my experimental maven repository on bintray.

@abelsromero
Member

I think that the build process needs to be documented at some point.

@abelsromero
Member

I also tested on MacOS and worked fine.

@mojavelinux
Member

The travis build tries to also build against the next dev version of asciidoctor, which would be 1.5.5.dev. As this is not available the second build fails after the first successful build.

See #484.

@mojavelinux
Member

It's really important that we get to a green build. Otherwise, we're going to miss errors as they come into master.

@robertpanzer
Member

Restarted the CI build on travis and the Oracle JDK builds are green now.

@ancho
Contributor
ancho commented Jul 15, 2016

travis has still problems with openjdk builds. See travis-ci/travis-ci#5227

So maybe we can try the workaround and manipulate the /etc/hosts file.

before_install:
  - sudo hostname "$(hostname | cut -c1-63)"
  - (cat /etc/hosts ; echo 127.0.0.1 $(hostname)) | sudo tee /etc/hosts
ancho added some commits Jul 15, 2016
@ancho ancho apply workaround for travis build with openjdk 7
See travis-ci/travis-ci#5227 for more information
20246ec
@ancho ancho skip signing in travis builds explitcit to prevent the openjdk 6 buil…
…d to crash
35d6351
@ancho
Contributor
ancho commented Jul 15, 2016

Hurray! 🎉
Everything is green again \o/

@robertpanzer robertpanzer merged commit 77e8070 into asciidoctor:master Jul 16, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@robertpanzer
Member

Thanks a lot! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment