Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Multiple small changes #509
Sorry to submit multiple changes in one pull request (and not using branches), but I had to make these changes in quick succession and could not isolate them. They are independent of each other, however. There are three changes:
Convert nested Java maps to Ruby hashes in
I'm not sure about this change, since I had to choose one of several different methods to convert Java maps to Ruby hashes in
Add getter for
I hope these changes are useful for you and that you can apply them. I have run the tests in the asciidoctorj-asciidoctorj and asciidoctorj-distribution projects and there were no failures.
Thanks a lot for your great contribution, Kristian!
Would you mind adding tests for the three problems you fixed?
That would help us a lot and would avoid that we later stumble over these problems again.
Thanks a lot! Such tests really help us.
There are a couple of code style problems that codenarc complains.
Thanks a lot!
Yes, there are some problems with Asciidoctor PDF and JRuby on Windows.