New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrained/unconstrained quotes #6

Closed
kikijiki opened this Issue Jun 1, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@kikijiki

kikijiki commented Jun 1, 2018

Quotes should be doubled when there is no space before/after the text.

In my case the documents are in Japanese, so there is no space between words. An example:

Markdown text: 計算の過程で`NaN`や`Inifinite`が出た際に
Kramdoc output: 計算の過程で`NaN`や`Inifinite`が出た際に
Expected output: 計算の過程で``NaN``や``Inifinite``が出た際に

@mojavelinux

This comment has been minimized.

Member

mojavelinux commented Jun 7, 2018

Indeed, this is one of the remaining conversions that need to be done. However, before I do that, I'm refactoring the code to make it more flexible. Once that is done, adding support for unconstrained formatting should be possible.

@mojavelinux mojavelinux self-assigned this Jun 30, 2018

mojavelinux added a commit to mojavelinux/kramdown-asciidoc that referenced this issue Jun 30, 2018

@mojavelinux mojavelinux added this to the v1.0.0 milestone Jun 30, 2018

mojavelinux added a commit to mojavelinux/kramdown-asciidoc that referenced this issue Jul 1, 2018

@mojavelinux

This comment has been minimized.

Member

mojavelinux commented Jul 1, 2018

I've added basic support. There may still be edge case. If you find them, please submit a separate issue that is specific to the case.

@kikijiki

This comment has been minimized.

kikijiki commented Jul 1, 2018

Cool, thank you for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment