Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bing_video don't kike "older" FF versions #1882

Closed
return42 opened this issue Mar 4, 2020 · 3 comments
Closed

bing_video don't kike "older" FF versions #1882

return42 opened this issue Mar 4, 2020 · 3 comments
Assignees

Comments

@return42
Copy link
Collaborator

@return42 return42 commented Mar 4, 2020

Bing video seems not to work with "older" FFox version, there is a interim fix ad7a6e6 but this might need some more work in the near future .. about FFox versions see #933

@return42 return42 self-assigned this Mar 4, 2020
@unixfox

This comment has been minimized.

Copy link
Contributor

@unixfox unixfox commented Mar 4, 2020

Maybe @dalf could bring the httpx_firefox branch into master?

@MarcAbonce

This comment has been minimized.

Copy link
Contributor

@MarcAbonce MarcAbonce commented Mar 5, 2020

If you run ./manage.sh update_useragents right now it already updates useragents.json to use Firefox versions older than 70 which is better than hardcoding the user agent, in my opinion.

But yeah, ideally I guess it would be better to automatically run that script somewhere instead of waiting for things to break before we remember to update our user agents. But for now, we can just manually run it once every couple of months or so. Browsers release new versions very often this days...

@return42

This comment has been minimized.

Copy link
Collaborator Author

@return42 return42 commented Mar 5, 2020

But yeah, ideally I guess it would be better to automatically run that script somewhere instead of waiting for things to break before we remember to update our user agents

If have such a task on my (long) todo list .. in PR #1803 I added a Makefile target project to re-build generic files of the searx project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.