New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #1209 #1278

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@dalf
Collaborator

dalf commented Apr 22, 2018

Implement #1209 :

  • settings.yml has the same format as before
  • doi.yml, locales.yml and engines.yml are loaded before (the disabled attributes are removed)
  • if yaml search.engines path is defined, then all engines are disabled, and only engine specified in this list are enabled.
  • settings.yml contans only general, search, server, ui sections. The search section contains the enabled engines.
  • settings_robot.yml is unchanged
Implement #1209
- settings.yml has the same format as before
- doi.yml, locales.yml and engines.yml are loaded before (the disabled attributes are removed)
- if yaml search.engines path is defined, then all engines are disabled, and only engine specified in this list are enabled.
- settings.yml contans only general, search, server, ui sections. The search section contains the enabled engines.
- settings_robot.yml is unchanged
@dalf

This comment has been minimized.

Show comment
Hide comment
@dalf

dalf Apr 22, 2018

Collaborator

Some notes :

  • In this implementation an administrator can't define its own engine. I think that "search.engines_yaml" and "search.include_engines_yaml" should be added in settings.yml. The first one to replace engines.yml path, the second to add another engines.yml.
  • May be doi.yml, locales.yml, and engines.yml should be moved to the same directory than currencies.json and engines_languages.json ?
Collaborator

dalf commented Apr 22, 2018

Some notes :

  • In this implementation an administrator can't define its own engine. I think that "search.engines_yaml" and "search.include_engines_yaml" should be added in settings.yml. The first one to replace engines.yml path, the second to add another engines.yml.
  • May be doi.yml, locales.yml, and engines.yml should be moved to the same directory than currencies.json and engines_languages.json ?

@dalf dalf requested a review from asciimoo Apr 22, 2018

@dalf

This comment has been minimized.

Show comment
Hide comment
@dalf

dalf Apr 22, 2018

Collaborator

Add two new settings :

  • search.engines_path : path of engines.yml
  • search.include_engines_path : additional engine definitions (doesn't replace the content of engines.yml)

doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix). Avoid to have settings about engines inside doi.yml for example.

Note that the DOI settings have changed.

Some bug fixes on oa_doi_rewrite.

Collaborator

dalf commented Apr 22, 2018

Add two new settings :

  • search.engines_path : path of engines.yml
  • search.include_engines_path : additional engine definitions (doesn't replace the content of engines.yml)

doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix). Avoid to have settings about engines inside doi.yml for example.

Note that the DOI settings have changed.

Some bug fixes on oa_doi_rewrite.

- search.engines_path : path of engines.yml
- search.include_engines_path : add engines definition (doesn't replace the content of engines.yml)

doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix)
some bug fixes on oa_doi_rewrite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment