Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bing engine results count #1387

Merged
merged 7 commits into from Aug 5, 2019

Conversation

@bourrel
Copy link
Contributor

commented Aug 29, 2018

This PR fixes the result count from bing which was throwing an (hidden) error and add a validation to avoid reading more results than avalaible.

For example :
If there is 100 results from some search and we try to get results from 120 to 130, Bing will send back the results from 0 to 10 and no error. If we compare results count with the first parameter of the request we can avoid this "invalid" results.

bourrel added some commits Aug 29, 2018

@dalf dalf added this to In progress in Engines via automation Apr 9, 2019

@dalf dalf added the engine label Apr 9, 2019

@dalf dalf added this to In progress in Next via automation Jul 24, 2019

@dalf dalf moved this from In progress to To do in Next Jul 24, 2019

dalf added some commits Aug 5, 2019

@dalf dalf merged commit 88261e1 into asciimoo:master Aug 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Engines automation moved this from In progress to Done Aug 5, 2019

Next automation moved this from To do to Done Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.