Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] speed optimization #1744

Merged
merged 1 commit into from Dec 2, 2019
Merged

[mod] speed optimization #1744

merged 1 commit into from Dec 2, 2019

Conversation

@dalf
Copy link
Collaborator

dalf commented Nov 15, 2019

Speed optimizations on slow servers:

  • avoid redundant call to urlparse
  • get_locale(webapp.py): avoid useless call to request.accept_languages.best_match
  • compile XPath only once.

About XPath: it is the optimization of the wikidata engines applied to other engines, not all.
If the modification are accepted, I will amend the commit / add a new commit to do it for all engines.

compile XPath only once
avoid redundant call to urlparse
get_locale(webapp.py): avoid useless call to request.accept_languages.best_match
Copy link
Owner

asciimoo left a comment

Great, thanks!

@asciimoo asciimoo merged commit 731e342 into asciimoo:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.