New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support server URLs without appended file extension #44

Open
tomas opened this Issue Jul 27, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@tomas
Copy link

tomas commented Jul 27, 2018

Hi, I'm trying to run asciicast2gif against a recording I just posted online, but I'm getting the following output:

==> Loading https://asciinema.org/a/AsPWpL1qCvInbNAAVBfbDfRhy...
only asciicast v1 and v2 formats can be opened
==> Done.

Running locally it doesn't work, as well:

==> Loading /tmp/tmpi1soul1l-ascii.cast...
==> Spawning PhantomJS renderer...
==> Generating frame screenshots...
==> Couldn't get geometry of requested DOM element
/usr/local/lib/node/lib/node_modules/asciicast2gif/main.js:696
[ ... ]

Any pointers? Thanks!

@funilrys

This comment has been minimized.

Copy link

funilrys commented Aug 15, 2018

👍 I get the same here ...

@tomas

This comment has been minimized.

Copy link
Author

tomas commented Sep 19, 2018

Ping @sickill :)

@dhimmel

This comment has been minimized.

Copy link

dhimmel commented Oct 7, 2018

I got the same error message when passing an asciinema.org URL. However, after looking into it, there doesn't appear to be a version 3 of the asciicast format and when I run asciinema --version locally, it showed I have version 2.0.0 which should be using the asciicast v2 format.

Hence, I realized we're just passing URLs that don't resolve to asciicast files. If you append .cast to the asciinema.org URL, then asciicast2gif should work. Try:

asciicast2gif https://asciinema.org/a/AsPWpL1qCvInbNAAVBfbDfRhy.cast output.gif

Perhaps a better error message in this case or support for asciinema.org URLs would be good enhancements.

@0xbkt

This comment has been minimized.

Copy link

0xbkt commented Oct 28, 2018

@dhimmel It didn't work for me.

@dhimmel

This comment has been minimized.

Copy link

dhimmel commented Oct 29, 2018

It didn't work for me.

It would be helpful to see the command you ran and the output that was provided.

@sickill

This comment has been minimized.

Copy link
Contributor

sickill commented Nov 16, 2018

@dhimmel is correct, right now you need to add .cast (or .json) ext to the URL, since asciicast2gif can't resolve it.

asciicast

It would definitely be nice if it happened automatically. I plan to work on better content-type negotiation support on server side, this should solve this case then.

@sickill sickill changed the title Support for newer versions? Support passing server URLs without appended file extension Nov 16, 2018

@sickill sickill changed the title Support passing server URLs without appended file extension Support server URLs without appended file extension Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment