Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nethack with curses graphics displays poorly in the web player #124

Closed
mihaifm opened this issue Dec 14, 2019 · 3 comments
Closed

nethack with curses graphics displays poorly in the web player #124

mihaifm opened this issue Dec 14, 2019 · 3 comments

Comments

@mihaifm
Copy link

mihaifm commented Dec 14, 2019

There seems to be a problem with the web player not displaying some things properly. Unfortunately I have no knowledge of how asciinema works to provide more details, however I attached the cast.

demo cast

Expected output (in the terminal, with asciinema play)

Screenshot from 2019-12-14 15-14-12

Actual web player output:

Screenshot from 2019-12-14 15-15-15

@sickill
Copy link
Contributor

sickill commented Nov 13, 2021

Found it! It was missing support for XTerm control sequence REP (https://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h4-Functions-using-CSI-_-ordered-by-the-final-character-lparen-s-rparen:CSI-Ps-b.1CA2).

It looks like expected now:

Zrzut ekranu 2021-11-13 o 20 15 47

The patch is in develop now, will be released soon with v3.0.0-beta.3.

@mihaifm
Copy link
Author

mihaifm commented Nov 14, 2021

Awesome, thanks for the great work.

@sickill
Copy link
Contributor

sickill commented Dec 11, 2021

New player with the fix has been pushed npmjs.org, and asciinema.org was updated to use it already.

@sickill sickill closed this as completed Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants