Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README examples with the options at the end #158

Merged
merged 1 commit into from Nov 21, 2021

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Nov 20, 2021

It seems to me that options are now passed as an object in the last argument to create, and so we need to update the examples in the README accordingly. That’s at least the only way it could work for me.

Thanks a lot for your work on this new version, I particularly love the fit option and the use of WASM.

As options are now passed as an object in the last argument to `create`, we need to update the examples in the README accordingly.
@ku1ik
Copy link
Contributor

ku1ik commented Nov 21, 2021

Good catch, thanks. And thanks for the feedback!

@ku1ik ku1ik merged commit 230525a into asciinema:develop Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants