Update README examples with the options at the end#158
Merged
ku1ik merged 1 commit intoasciinema:developfrom Nov 21, 2021
Merged
Update README examples with the options at the end#158ku1ik merged 1 commit intoasciinema:developfrom
ku1ik merged 1 commit intoasciinema:developfrom
Conversation
As options are now passed as an object in the last argument to `create`, we need to update the examples in the README accordingly.
Contributor
|
Good catch, thanks. And thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to me that options are now passed as an object in the last argument to
create, and so we need to update the examples in the README accordingly. That’s at least the only way it could work for me.Thanks a lot for your work on this new version, I particularly love the
fitoption and the use of WASM.