New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-archival of unclaimed asciicasts (GC) #333

Merged
merged 16 commits into from Dec 16, 2018

Conversation

Projects
None yet
1 participant
@sickill
Copy link
Contributor

sickill commented Dec 8, 2018

This PR adds ability to auto-archive asciicasts that have been uploaded by anonymous users (from unknown/unregistered installations).

For users who haven't linked their local installation to their online account (via asciinema auth command) we're gonna display information about enabled archival in the upload result message, on each upload (or implicit upload when asciinema rec without arg used).

The idea behind this feature is to "garbage collect" dead recordings (where "dead" == watched/shared, then forgotten/abandoned), which will clean up storage. It will also ensure the recordings that are preserved are linked to real user accounts, and these users can be reached (abuse reports etc).

Archival will not delete the recordings, only mark them as archived, which will result in hiding it from all listings, and showing "This recording has been archived" message for direct asciicast links. Actual removal from database and file store will happen N days after archival, and will be part of a separate PR.

Archival is disabled by default, and can be enabled by setting ASCIICAST_GC_DAYS env variable to the number of days after which anonymous recording is archived.

We're going to enable this on asciinema.org.

@sickill sickill merged commit 5956f6e into develop Dec 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment