Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging of asciinema 2.2.0 #116

Open
sickill opened this issue Jun 30, 2015 · 64 comments
Open

Packaging of asciinema 2.2.0 #116

sickill opened this issue Jun 30, 2015 · 64 comments

Comments

@sickill
Copy link
Contributor

sickill commented Jun 30, 2015

Opening this issue to discuss the best way for package maintainers to be notified about new asciinema releases.

We could create a mailing list for this, or use https://github.com/asciinema/asciinema/releases.atom like @jakubjedelsky suggested (#43 (comment)). Alternatively I could be reopening this issue and pinging you here in the comments whenever new release is out. Any other ideas and/or preferences?

/cc @jakubjedelsky @zanchey @Dr-Terrible @larryv

UPDATE: So I just keep this issue open and comment when there's new release. Package maintainers can subscribe to this issue to get notified.

@sickill
Copy link
Contributor Author

sickill commented Jun 30, 2015

/cc @swills

@zanchey
Copy link

zanchey commented Jun 30, 2015

The atom feed is enough for me. SourceForge used to be the place for mailing lists, but I think they've gone a bit evil now. We have a mailman server if you want to use that.

@Dr-Terrible
Copy link

Dr-Terrible commented Jun 30, 2015

The atom feed is enough for me too.
If by any chance I miss a release and users are complaining, feel free to poke me via GitHub's issues through my Gentoo overlay.

@swills
Copy link
Contributor

swills commented Jun 30, 2015

Personally, I'd prefer an email of some kind, either mailing list or github issue email, either is fine. Thanks!

@larryv
Copy link

larryv commented Jul 1, 2015

I'd also prefer email notifications (to minimize update lag), but I'd be fine with the atom feed.

@sickill
Copy link
Contributor Author

sickill commented Feb 22, 2016

I have just released 1.2.0 /cc @larryv @swills @Dr-Terrible @zanchey @jakubjedelsky

@Dr-Terrible
Copy link

Dr-Terrible commented Feb 22, 2016

@sickill Done! Thank you for the reminder.

v1.2.0 tested with both Go1.4.x and Go1.5.x (Gentoo/Linux x86-64), and everything works as expected, with all the unit tests passing. Ebuild just pushed in my overlay: Dr-Terrible/go-overlay@4859682.

@sickill
Copy link
Contributor Author

sickill commented Feb 22, 2016

@Dr-Terrible wow, that was quick! Thanks!

@sickill
Copy link
Contributor Author

sickill commented Mar 2, 2016

@youtux thanks for updating Homebrew package!

@youtux
Copy link

youtux commented Mar 2, 2016

@sickill you are welcome. Also, I use sibbell.com to get updates via email every time a starred github project gets a new tag.

@zanchey
Copy link

zanchey commented Mar 6, 2016

I've updated the Ubuntu packages; sorry for the delay.

@sickill
Copy link
Contributor Author

sickill commented Mar 6, 2016

@zanchey thanks!

@larryv
Copy link

larryv commented May 14, 2016

updated in MacPorts, only 3 months late 😓

@sickill
Copy link
Contributor Author

sickill commented May 14, 2016

@larryv no prob, thanks!

@sickill
Copy link
Contributor Author

sickill commented Jul 13, 2016

We have a new release! This new 1.3 version is back on Python (read more about it here: http://blog.asciinema.org/post/and-now-for-something-completely-different/). Sorry if this adds you more work (switching build toolchain from Go to Python)! But I believe in the long run the packaging will be simpler, especially that as of this version we have zero external dependencies 💥

@Dr-Terrible
Copy link

Dr-Terrible commented Jul 15, 2016

Sorry @sickill, I can't add a python package to my go overlay, so I'm forced to remove asciinema. Or at least, I'll keep and maintain the previous Golang implementations, but not the new ones in python (there are too many dependencies to wrangle).

@sickill
Copy link
Contributor Author

sickill commented Jul 15, 2016

@Dr-Terrible ok. Maybe original portage package maintainers will be able to update the 0.9.8 ebuild to 1.3.0. Thanks!

@larryv
Copy link

larryv commented Jul 15, 2016

Updated in MacPorts. As you can see from that diff, switching back to Python made things rather easier for me. Thank you! 😄

@Dr-Terrible
Copy link

Dr-Terrible commented Jul 16, 2016

@sickill I think so, but at the moment there is no maintainer for the ebuild, so it will take some time before asciinema will be properly added to the Portage tree. To speed up a little the process, I think I'm going to submit a proper ebuild (at least for v1.3.0) in the next days, if I'm not too busy doing other stuff.

@jakubjedelsky
Copy link
Contributor

jakubjedelsky commented Jul 16, 2016

Love the change to python3, it's much more better to package it for me. Builds for Fedora 24,23 and EPEL 7 are prepared and will go to testing repos soon.

@zanchey
Copy link

zanchey commented Jul 17, 2016

Done in the Ubuntu PPA. Likewise, the packaging is significantly smaller now.

@gfa
Copy link

gfa commented Jul 29, 2016

i'm the maintainer for debian, I've recently subscribed to the blog, i'll subscribe to the releases atom feed.
I prefer email but i run a rss-> email gateway so is the same for me

working on the 1.3.0 package, just a week latter i finished to work on go package, please don't switch language implementations again

@sickill
Copy link
Contributor Author

sickill commented Jul 30, 2016

@gfa thanks for your work Gustavo. No worries, we are staying with Python for good.

@swills
Copy link
Contributor

swills commented Aug 2, 2016

Finally updated to 1.3.0 in FreeBSD ports. Thanks for the heads up.

@sickill
Copy link
Contributor Author

sickill commented Aug 2, 2016

@swills awesome, thanks!

@sickill
Copy link
Contributor Author

sickill commented Apr 11, 2017

Hey there good people! We have a new release, 1.4.0 - https://pypi.python.org/pypi/asciinema/1.4.0

@sickill sickill changed the title Notifying package maintainers about new releases Packaging of asciinema 1.4.0 Apr 11, 2017
@zanchey
Copy link

zanchey commented Apr 6, 2018

Done.

@sickill
Copy link
Contributor Author

sickill commented Apr 6, 2018

@zanchey great, thx!

@just4t
Copy link

just4t commented Jul 8, 2018

Started today with asciinema ... First of all, thanks a lot for the tool and service.
Installed as snap app. in Linux Mint 19c desktop and over an Ubuntu 18.04 LTS powered cloud server and looks it works perfectly, but ...

  • Just noticed the installed version via snapd app. is the 1.4 and not a latest 2.0.1+ ... !?

  • Have you plans to release the asciinema 2.0.1+ snap app. package soon?

@sickill
Copy link
Contributor Author

sickill commented Jul 8, 2018

@flexiondotorg any chance you could update snap to 2.0.1?

@sickill
Copy link
Contributor Author

sickill commented Sep 10, 2018

I have temporarily removed snap installation option. It doesn't seem anyone is maintaining it anymore.

@sickill sickill changed the title Packaging of asciinema 2.0.1 Packaging of asciinema 2.0.2 Apr 28, 2019
@sickill
Copy link
Contributor Author

sickill commented Apr 28, 2019

It seems Ubuntu 18.04 has asciinema 2.0.0 (https://packages.ubuntu.com/bionic/asciinema) and 19.04 has 2.0.2 (https://packages.ubuntu.com/disco/asciinema). Any chance you can update your ppa @zanchey to 2.0.2 for those on older Ubuntu and Debian versions?

@zanchey
Copy link

zanchey commented May 14, 2019

Done! I ended up reusing my packaging metadata, rather than copying from 19.04, as the debhelper requirements are too high for the backport to work easily.

@sickill
Copy link
Contributor Author

sickill commented May 14, 2019

@zanchey great! Thank you 🏆

@om26er
Copy link

om26er commented Jan 10, 2020

@sickill since I have been the maintainer of the snap package, I think it would make sense to bring back the snap installation instructions, probably elevated as "recommended" for Linux based systems. I had created an issue #382 before I came here.

@mario23174
Copy link

mario23174 commented Sep 14, 2020

1

@aarek-eng
Copy link

aarek-eng commented Jun 23, 2021

Installation via pip didn't work on Windows 10. Is it an issue with my setup, or do I need to create a venv, or...? Please let me know what information is missing, and I'll try and provide it.

PS C:\Users\user\Documents\GitHub\vagrant> pip install asciinema
Collecting asciinema
  Downloading asciinema-2.0.2.tar.gz (35 kB)
    ERROR: Command errored out with exit status 1:
     command: 'c:\users\user\appdata\local\programs\python\python39\python.exe' -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\user\\AppData\\Local\\Temp\\pip-install-p1stt4vv\\asciinema_6b62e678e99c46198b216b8875ea9855\\setup.py'"'"'; __file__='"'"'C:\\Users\\user\\AppData\\Local\\Temp\\pip-install-p1stt4vv\\asciinema_6b62e678e99c46198b216b8875ea9855\\setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\user\AppData\Local\Temp\pip-pip-egg-info-ui2m3wmb'
         cwd: C:\Users\user\AppData\Local\Temp\pip-install-p1stt4vv\asciinema_6b62e678e99c46198b216b8875ea9855\
    Complete output (9 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\user\AppData\Local\Temp\pip-install-p1stt4vv\asciinema_6b62e678e99c46198b216b8875ea9855\setup.py", line 1, in <module>
        import asciinema
      File "C:\Users\user\AppData\Local\Temp\pip-install-p1stt4vv\asciinema_6b62e678e99c46198b216b8875ea9855\asciinema\__init__.py", line 15, in <module>
        import asciinema.pty as pty
      File "C:\Users\user\AppData\Local\Temp\pip-install-p1stt4vv\asciinema_6b62e678e99c46198b216b8875ea9855\asciinema\pty.py", line 3, in <module>
        import fcntl
    ModuleNotFoundError: No module named 'fcntl'
    ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/a7/71/771c859795e02c71c187546f34f7535487b97425bc1dad1e5f6ad2651357/asciinema-2.0.2.tar.gz#sha256=32f2c1a046564e030708e596f67e0405425d1eca9d5ec83cd917ef8da06bc423 (from https://pypi.org/simple/asciinema/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
  Downloading asciinema-2.0.1.tar.gz (17 kB)
Building wheels for collected packages: asciinema
  Building wheel for asciinema (setup.py) ... done
  Created wheel for asciinema: filename=asciinema-2.0.1-py3-none-any.whl size=19340 sha256=49c998fc7f48557e13c3e601bab478308f6e05b14a48e8448d58e5cdae0ba905
  Stored in directory: c:\users\user\appdata\local\pip\cache\wheels\ff\09\e7\4fc5109471fd53152f2b6a1b570c6e1ca879383edc3ce73445
Successfully built asciinema
Installing collected packages: asciinema
Successfully installed asciinema-2.0.1
PS C:\Users\user\Documents\GitHub\vagrant> asciinema rec
Traceback (most recent call last):
  File "c:\users\user\appdata\local\programs\python\python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\user\appdata\local\programs\python\python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\user\AppData\Local\Programs\Python\Python39\Scripts\asciinema.exe\__main__.py", line 4, in <module>
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\asciinema\__main__.py", line 9, in <module>
    from asciinema.commands.record import RecordCommand
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\asciinema\commands\record.py", line 6, in <module>
    import asciinema.asciicast as asciicast
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\asciinema\asciicast\__init__.py", line 11, in <module>
    from . import v2
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\asciinema\asciicast\v2.py", line 9, in <module>
    from asciinema.pty_recorder import PtyRecorder
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\asciinema\pty_recorder.py", line 3, in <module>
    import pty
  File "c:\users\user\appdata\local\programs\python\python39\lib\pty.py", line 12, in <module>
    import tty
  File "c:\users\user\appdata\local\programs\python\python39\lib\tty.py", line 5, in <module>
    from termios import *
ModuleNotFoundError: No module named 'termios'
PS C:\Users\user\Documents\GitHub\vagrant>

@sickill sickill closed this as completed Oct 3, 2021
@sickill sickill changed the title Packaging of asciinema 2.0.2 Packaging of asciinema 2.1.0 Oct 3, 2021
@sickill
Copy link
Contributor Author

sickill commented Oct 3, 2021

I've just pushed 2.1.0 to pypi.org.

@sickill sickill reopened this Oct 3, 2021
@chenrui333
Copy link

chenrui333 commented Oct 5, 2021

@sickill
Copy link
Contributor Author

sickill commented Oct 5, 2021

Thanks @chenrui333 .

So thanks to @gpotter2 the release setup has been modernized, like this https://github.com/asciinema/asciinema/pull/422/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R22-R24 , but I'm not sure how to make it build/upload tgz. Any tips? I don't often release Python packages and I'm new to twine/wheel...

@sickill
Copy link
Contributor Author

sickill commented Oct 26, 2021

The issue with missing tgz file on pypi is now solved.

@om26er
Copy link

om26er commented Oct 26, 2021

Forgot to mention here previously: The asciinema snap is now at version 2.1.0 for a few weeks. http://snapcraft.io/asciinema

I hope we can add that to install instructions as well.

@harkabeeparolus
Copy link
Contributor

harkabeeparolus commented Dec 1, 2021

Regarding the installation instructions, I propose that the Pip section is amended.

  • I would suggest using pipx as the primary way to install Python tools or utilities. It's an official Python Packaging Authority project nowadays, and all the Python podcasts and news sources speak highly of it.

    You can install permanently with pipx install asciinema, or run a one-off with pipx run asciinema play demo.cast.

  • I would also suggest not using sudo if you're using pip.

    The recommended incantation is python3 -m pip install asciinema. For ancient versions of pip, you need to specify --user as in python3 -m pip install --user asciinema, but recent pip versions default to the user's home directory when the python site-packages folder is not writable.

Rationale for both points above: See this blog post by Python steering council member and core developer Brett Cannon:
Why you should use python -m pip

I suggest the following:

Installing via Pip

asciinema is available on PyPI and can be installed with pipx or pip (Python 3 required):

pipx install asciinema

Or with pip (using your preferred python version):

python3 -m pip install asciinema

This is the universal installation method for all operating systems, which always provides the latest version.

@sickill
Copy link
Contributor Author

sickill commented Dec 8, 2021

Thanks for the idea and great summary @harkabeeparolus. This sounds good to me. Would you care to open a PR with the proposed change?

@harkabeeparolus
Copy link
Contributor

harkabeeparolus commented Dec 11, 2021

Thanks for the idea and great summary @harkabeeparolus. This sounds good to me. Would you care to open a PR with the proposed change?

Sure, I can make a PR against your README.md file!

However, I can't find the repo for your official documentation: https://asciinema.org/docs/installation
...So I'm guessing an official team member would have to update that. 😄

@Wittionary
Copy link

Wittionary commented Jan 14, 2022

I'm running into the same error as @aarek-eng , ModuleNotFoundError: No module named 'fcntl'.
It seems this module is not available for Windows users (StackOverflow) because it's a unix/linux system call - unless I'm looking at the wrong thing.

I haven't taken a look at the asciinema source to see how large of an effort this would be, but is there the possibility of adding an alternate, Windows-supported file control library?

@rollingmoai
Copy link

rollingmoai commented Feb 17, 2022

This works for windows: https://github.com/Watfaq/PowerSession

@sickill sickill changed the title Packaging of asciinema 2.1.0 Packaging of asciinema 2.2.0 May 7, 2022
@sickill
Copy link
Contributor Author

sickill commented May 7, 2022

Please discuss Windows issues in separate issues (we do have a couple of them laying around). Thx!

@sickill
Copy link
Contributor Author

sickill commented May 7, 2022

I've just pushed 2.2.0 to pypi.org.

@zanchey
Copy link

zanchey commented May 15, 2022

I've updated my PPA. I don't use Ubuntu any more, and pipx looks like a better way to install in general, but the packages should still work. Debian doesn't have a good story for builds without a setup.py, so I added a patch that ships a minimal version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

17 participants