New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on OpenBSD: undefined: Termios #144

Closed
ligurio opened this Issue Feb 7, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@ligurio

ligurio commented Feb 7, 2016

5.8 GENERIC.MP#1236

$ go get github.com/asciinema/asciinema

github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw

source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:10: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:11: undefined: setTermios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:18: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:19: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:20: undefined: getTermios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:36: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:49: undefined: Termios

github.com/asciinema/asciinema/util

source/go/src/github.com/asciinema/asciinema/util/copy.go:34: undefined: FD_SET
source/go/src/github.com/asciinema/asciinema/util/copy.go:35: undefined: FD_SET
source/go/src/github.com/asciinema/asciinema/util/copy.go:37: undefined: Select
source/go/src/github.com/asciinema/asciinema/util/copy.go:47: undefined: FD_ISSET
source/go/src/github.com/asciinema/asciinema/util/copy.go:72: undefined: FD_ISSET
$

@aerth

This comment has been minimized.

Show comment
Hide comment
@aerth

aerth Feb 12, 2016

Similar error building on netbsd 😢

# github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:10: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:11: undefined: setTermios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:18: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:19: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:20: undefined: getTermios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:36: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:49: undefined: Termios
# github.com/asciinema/asciinema/util
util/copy.go:34: undefined: FD_SET
util/copy.go:35: undefined: FD_SET
util/copy.go:37: undefined: Select
util/copy.go:47: undefined: FD_ISSET
util/copy.go:72: undefined: FD_ISSET
*** Error code 2

aerth commented Feb 12, 2016

Similar error building on netbsd 😢

# github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:10: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:11: undefined: setTermios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:18: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:19: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:20: undefined: getTermios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:36: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:49: undefined: Termios
# github.com/asciinema/asciinema/util
util/copy.go:34: undefined: FD_SET
util/copy.go:35: undefined: FD_SET
util/copy.go:37: undefined: Select
util/copy.go:47: undefined: FD_ISSET
util/copy.go:72: undefined: FD_ISSET
*** Error code 2
@sickill

This comment has been minimized.

Show comment
Hide comment
@sickill

sickill Feb 13, 2016

Contributor

Looks like creack/termios lib doesn't support OpenBSD and NetBSD....

Contributor

sickill commented Feb 13, 2016

Looks like creack/termios lib doesn't support OpenBSD and NetBSD....

@sickill

This comment has been minimized.

Show comment
Hide comment
@sickill

sickill Feb 21, 2016

Contributor

I'm not really familiar with *BSD systems but if anyone can look at this I'd be happy to accept a PR!

Contributor

sickill commented Feb 21, 2016

I'm not really familiar with *BSD systems but if anyone can look at this I'd be happy to accept a PR!

@sickill sickill added the packaging label Mar 26, 2016

@ligurio

This comment has been minimized.

Show comment
Hide comment
@ligurio

ligurio May 31, 2016

These patches fix creack/termios and asciinema for OpenBSD:

But in rest we have a problem with undefined syscall.Termios:

-bash-4.2$ go build
# golang.org/x/crypto/ssh/terminal
../../../golang.org/x/crypto/ssh/terminal/util.go:27: undefined: syscall.Termios
-bash-4.2$

and I don't know how to resolve it.

ligurio commented May 31, 2016

These patches fix creack/termios and asciinema for OpenBSD:

But in rest we have a problem with undefined syscall.Termios:

-bash-4.2$ go build
# golang.org/x/crypto/ssh/terminal
../../../golang.org/x/crypto/ssh/terminal/util.go:27: undefined: syscall.Termios
-bash-4.2$

and I don't know how to resolve it.

@sickill sickill added this to the 1.3.0 milestone Jul 6, 2016

@sickill

This comment has been minimized.

Show comment
Hide comment
@sickill

sickill Jul 13, 2016

Contributor

@ligurio Thanks for the patches! I don't know how to resolve the last problem either.

Anyway, I just released v1.3.0. It solves this problem (and many others!) because it's implemented in Python (it's based on v0.9.8 codebase) so it doesn't have a compilation step. Can you check it out? sudo pip3 install asciinema.

Contributor

sickill commented Jul 13, 2016

@ligurio Thanks for the patches! I don't know how to resolve the last problem either.

Anyway, I just released v1.3.0. It solves this problem (and many others!) because it's implemented in Python (it's based on v0.9.8 codebase) so it doesn't have a compilation step. Can you check it out? sudo pip3 install asciinema.

@ligurio

This comment has been minimized.

Show comment
Hide comment
@sickill

This comment has been minimized.

Show comment
Hide comment
@sickill

sickill Jul 13, 2016

Contributor

Thanks! I'll update the site to so it says we support OpenBSD now :)

Contributor

sickill commented Jul 13, 2016

Thanks! I'll update the site to so it says we support OpenBSD now :)

@sickill sickill closed this Jul 13, 2016

@ligurio

This comment has been minimized.

Show comment
Hide comment
@ligurio

ligurio Jul 13, 2016

Thank you!

ligurio commented Jul 13, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment