Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on OpenBSD: undefined: Termios #144

Closed
ligurio opened this issue Feb 7, 2016 · 8 comments
Closed

Build on OpenBSD: undefined: Termios #144

ligurio opened this issue Feb 7, 2016 · 8 comments
Milestone

Comments

@ligurio
Copy link

ligurio commented Feb 7, 2016

5.8 GENERIC.MP#1236

$ go get github.com/asciinema/asciinema

github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw

source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:10: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:11: undefined: setTermios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:18: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:19: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:20: undefined: getTermios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:36: undefined: Termios
source/go/src/github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:49: undefined: Termios

github.com/asciinema/asciinema/util

source/go/src/github.com/asciinema/asciinema/util/copy.go:34: undefined: FD_SET
source/go/src/github.com/asciinema/asciinema/util/copy.go:35: undefined: FD_SET
source/go/src/github.com/asciinema/asciinema/util/copy.go:37: undefined: Select
source/go/src/github.com/asciinema/asciinema/util/copy.go:47: undefined: FD_ISSET
source/go/src/github.com/asciinema/asciinema/util/copy.go:72: undefined: FD_ISSET
$

@aerth
Copy link

aerth commented Feb 12, 2016

Similar error building on netbsd 😢

# github.com/asciinema/asciinema/Godeps/_workspace/src/github.com/creack/termios/raw
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:10: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:11: undefined: setTermios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:18: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:19: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:20: undefined: getTermios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:36: undefined: Termios
Godeps/_workspace/src/github.com/creack/termios/raw/raw.go:49: undefined: Termios
# github.com/asciinema/asciinema/util
util/copy.go:34: undefined: FD_SET
util/copy.go:35: undefined: FD_SET
util/copy.go:37: undefined: Select
util/copy.go:47: undefined: FD_ISSET
util/copy.go:72: undefined: FD_ISSET
*** Error code 2

@ku1ik
Copy link
Contributor

ku1ik commented Feb 13, 2016

Looks like creack/termios lib doesn't support OpenBSD and NetBSD....

@ku1ik
Copy link
Contributor

ku1ik commented Feb 21, 2016

I'm not really familiar with *BSD systems but if anyone can look at this I'd be happy to accept a PR!

@ligurio
Copy link
Author

ligurio commented May 31, 2016

These patches fix creack/termios and asciinema for OpenBSD:

But in rest we have a problem with undefined syscall.Termios:

-bash-4.2$ go build
# golang.org/x/crypto/ssh/terminal
../../../golang.org/x/crypto/ssh/terminal/util.go:27: undefined: syscall.Termios
-bash-4.2$

and I don't know how to resolve it.

@ku1ik ku1ik added this to the 1.3.0 milestone Jul 6, 2016
@ku1ik
Copy link
Contributor

ku1ik commented Jul 13, 2016

@ligurio Thanks for the patches! I don't know how to resolve the last problem either.

Anyway, I just released v1.3.0. It solves this problem (and many others!) because it's implemented in Python (it's based on v0.9.8 codebase) so it doesn't have a compilation step. Can you check it out? sudo pip3 install asciinema.

@ligurio
Copy link
Author

ligurio commented Jul 13, 2016

Works fine. https://asciinema.org/a/79462

@ku1ik
Copy link
Contributor

ku1ik commented Jul 13, 2016

Thanks! I'll update the site to so it says we support OpenBSD now :)

@ku1ik ku1ik closed this as completed Jul 13, 2016
@ligurio
Copy link
Author

ligurio commented Jul 13, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants