Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload recording as private #66

Closed
omaraboumrad opened this issue Jul 15, 2014 · 10 comments
Closed

upload recording as private #66

omaraboumrad opened this issue Jul 15, 2014 · 10 comments
Milestone

Comments

@omaraboumrad
Copy link

@omaraboumrad omaraboumrad commented Jul 15, 2014

Kindly add a new feature to asciinema.org allowing users to change a recording's visibility.

Options: Public/Private

Example setting through terminal:

~ Asciicast recording finished.
~ Do you want to upload it? [Y/n] Y
~ Do you want to make it private? Y

Thank you!

@jottr
Copy link

@jottr jottr commented Sep 25, 2014

👍
IMHO instead of asking the user, a -p switch would be sufficient.
I would like to extend the wishlist to a -c switch to copy a casts url to clipboard and an -o to immediately open the cast in a browser.

@sickill
Copy link
Contributor

@sickill sickill commented Sep 25, 2014

I plan to add -p and -o switches like you described. -c is already used for specifying the command to record (like in su -c ..., bash -c ... etc). We would need to find another one for copy-to-clipboard. Maybe -C.. ?

@jottr
Copy link

@jottr jottr commented Sep 25, 2014

Since -c is already in use -C makes sense. Unless you would decide to remap -c to -e to execute a command. But that would break scripts already using asciinema (if such scripts even exist).
Maybe you could support long parameters as well? I.e. asciinema rec --copy --private --execute command

@ghost
Copy link

@ghost ghost commented Sep 29, 2014

I was surprised to see that my recording was public the first time I used it. Prompting
"Do you want to upload it as a public video? [y/n]" would be nice.

@jottr
Copy link

@jottr jottr commented Sep 29, 2014

I, for one, actually expected that. It's the same for githubs gist cli tool.
How about a .asciinema.rc where people can set their preferred standard privacy settings?

@ghost
Copy link

@ghost ghost commented Sep 29, 2014

.asciinema.rc would be nice! I still like to see an explicit message at the prompt if it's going to be public.

@sickill sickill modified the milestone: v0.9.9 Nov 10, 2014
@sickill sickill modified the milestones: v1.0.0, v0.9.9 Dec 14, 2014
@sickill
Copy link
Contributor

@sickill sickill commented Dec 14, 2014

There's ~/.asciinema/config file already. We can add support for record.private = true/false setting to it.

@KenSuenobu
Copy link

@KenSuenobu KenSuenobu commented Feb 25, 2015

👍

@sickill sickill modified the milestones: v1.1, v1.0.0 Mar 12, 2015
@sickill
Copy link
Contributor

@sickill sickill commented May 11, 2015

Good news! Private asciicasts just landed for everyone: http://blog.asciinema.org/post/private/

@sickill sickill closed this May 11, 2015
@KenSuenobu
Copy link

@KenSuenobu KenSuenobu commented May 11, 2015

AWESOME!!!!!!! Thank you so much for doing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.